[ http://issues.apache.org/jira/browse/WODEN-90?page=comments#action_12452320 ] Lawrence Mandel commented on WODEN-90: --------------------------------------
I don't think this one fix is a maintenance problem. I do think that taking on the responsibility to convert all file paths into valid URLs is a maintenance problem. In this case Woden will only convert the file paths from the Ant task so I think we're alright as the only client that we need to support is the Woden Ant client. I'll withdraw my previous -1 vote on this Jira. Also, given when Arthur stated about the Ant filesets, I think the Woden Ant task needs to support the common Ant structures and use them as expected by clients. Otherwise we risk alienating users that can't figure out how to pass in files to the Woden Ant task. > org.apache.woden.ant.validateWSDL20 mis-handles paths including whitespace > -------------------------------------------------------------------------- > > Key: WODEN-90 > URL: http://issues.apache.org/jira/browse/WODEN-90 > Project: Woden > Issue Type: Bug > Components: Validation > Reporter: Graham Turrell > Assigned To: Arthur Ryman > Attachments: Woden90Patch.txt > > > The ant-task "validatewsdl20" ( in ant-test/build.xml) is implemented by the > class (woden/src/)org.apache.woden.ant.validateWSDL20. This class includes > conversion of local filenames (testcase wsdl for the ant-tests) to String > representation of file:// URI's. > The code segment in the execute() method is currently: > String wsdlLoc = file.getAbsolutePath(); > wsdlLoc = wsdlLoc.replace('\\', '/'); > wsdlLoc = "file:///" + wsdlLoc; > This fails to convert any whitespace in the filepath to URI representation, > such that the resultant URI string is of the form file://<filepath with > whitespace>, which is an invalid URI. > Replacing the above 3 lines with > String wsdlLoc = file.toURI().toString(); > Should fix this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
