[ 
http://issues.apache.org/jira/browse/WODEN-90?page=comments#action_12452312 ] 
            
Arthur Ryman commented on WODEN-90:
-----------------------------------

Lawrence/Graham,

The execute method is not passed a regex of file paths. However, if you inherit 
from the appropriate class, the task acquires the ability to process FileSets 
which are a key Ant structure. They are defined by includes and excludes.

Ant is primarily a build technology, therefore it majors on processing sets of 
files.

However, you can define addition parameters, so I could extend it to accept a) 
a url, b) a file that contained a list of urls. These would be passed directly 
to Woden. But I do think the use of the fix:

String wsdlLoc = file.toURI().toString(); 

is fine.

Lawrence - why do you think this is a maintenance problem?

> org.apache.woden.ant.validateWSDL20 mis-handles paths including whitespace
> --------------------------------------------------------------------------
>
>                 Key: WODEN-90
>                 URL: http://issues.apache.org/jira/browse/WODEN-90
>             Project: Woden
>          Issue Type: Bug
>          Components: Validation
>            Reporter: Graham Turrell
>         Assigned To: Arthur Ryman
>         Attachments: Woden90Patch.txt
>
>
> The ant-task "validatewsdl20" ( in ant-test/build.xml) is implemented by the 
> class (woden/src/)org.apache.woden.ant.validateWSDL20. This class includes 
> conversion of  local filenames  (testcase wsdl for the ant-tests) to String 
> representation of file:// URI's.
> The code segment in the execute() method is currently:
>            String wsdlLoc = file.getAbsolutePath(); 
>            wsdlLoc = wsdlLoc.replace('\\', '/');
>            wsdlLoc = "file:///" + wsdlLoc;
> This fails to convert any whitespace in the filepath to URI representation, 
> such that the resultant URI string is of the form file://<filepath with 
> whitespace>, which is an invalid URI.
> Replacing the above 3 lines with  
>            String wsdlLoc = file.toURI().toString();
> Should fix this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to