[ http://issues.apache.org/jira/browse/WODEN-90?page=comments#action_12451071 ] Lawrence Mandel commented on WODEN-90: --------------------------------------
Is there a reason the ValdiateWSDL20 Ant task accepts a file path and not a URL? Is this an Ant convention/requirement? If the ValidateWSDL20 task has simply been written to accept a file path perhaps it should be changed to accept a URL. My concern is really around the maintenance of code that will take any file path and convert it into a correct URL. This type of routine can quickly get out of hand as anyone with any path will expect that the routine will satisfy them. With multiple platforms and ways of structuring file paths there are many ways the file path may be structured when passed to Woden and it will be difficult for Woden to convert correctly in every case. > org.apache.woden.ant.validateWSDL20 mis-handles paths including whitespace > -------------------------------------------------------------------------- > > Key: WODEN-90 > URL: http://issues.apache.org/jira/browse/WODEN-90 > Project: Woden > Issue Type: Bug > Components: Validation > Reporter: Graham Turrell > Assigned To: Arthur Ryman > Attachments: Woden90Patch.txt > > > The ant-task "validatewsdl20" ( in ant-test/build.xml) is implemented by the > class (woden/src/)org.apache.woden.ant.validateWSDL20. This class includes > conversion of local filenames (testcase wsdl for the ant-tests) to String > representation of file:// URI's. > The code segment in the execute() method is currently: > String wsdlLoc = file.getAbsolutePath(); > wsdlLoc = wsdlLoc.replace('\\', '/'); > wsdlLoc = "file:///" + wsdlLoc; > This fails to convert any whitespace in the filepath to URI representation, > such that the resultant URI string is of the form file://<filepath with > whitespace>, which is an invalid URI. > Replacing the above 3 lines with > String wsdlLoc = file.toURI().toString(); > Should fix this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
