[ http://issues.apache.org/jira/browse/WODEN-90?page=comments#action_12450892 ] Graham Turrell commented on WODEN-90: -------------------------------------
Lawrence, I agree that we should not be about correcting invalid URL's in Woden. However, a couple of points for this case: Firstly this isn't exactly a correction since ValidateWSDL20.execute() doesnt purport to accept a URL, but a filepath. Therfore we are dealing with a conversion to a URI not a correction. Secondly , it is the resulting URI that is passed into WSDLReader.readSWDL( ...). If one regards that method call as Woden then we would indeed be doing the conversion (in ValidateWSDL20) before passing to Woden (WSDLReader). I don't know if that completely addresses your concerns though? > org.apache.woden.ant.validateWSDL20 mis-handles paths including whitespace > -------------------------------------------------------------------------- > > Key: WODEN-90 > URL: http://issues.apache.org/jira/browse/WODEN-90 > Project: Woden > Issue Type: Bug > Components: Validation > Reporter: Graham Turrell > Assigned To: Arthur Ryman > Attachments: Woden90Patch.txt > > > The ant-task "validatewsdl20" ( in ant-test/build.xml) is implemented by the > class (woden/src/)org.apache.woden.ant.validateWSDL20. This class includes > conversion of local filenames (testcase wsdl for the ant-tests) to String > representation of file:// URI's. > The code segment in the execute() method is currently: > String wsdlLoc = file.getAbsolutePath(); > wsdlLoc = wsdlLoc.replace('\\', '/'); > wsdlLoc = "file:///" + wsdlLoc; > This fails to convert any whitespace in the filepath to URI representation, > such that the resultant URI string is of the form file://<filepath with > whitespace>, which is an invalid URI. > Replacing the above 3 lines with > String wsdlLoc = file.toURI().toString(); > Should fix this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
