[ 
https://issues.apache.org/jira/browse/YARN-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264977#comment-17264977
 ] 

Peter Bacsko commented on YARN-10506:
-------------------------------------

*Clarification comment*

I turned out I misunderstood [~shuzirra]'s comment above. I thought he was 
speaking about the "create" flag the comes from the rule itself. I should have 
read it more carefully.

Anyway we just had an internal meeting so now I have a better understanding.

_"How we deal with "create" flag of ApplicationPlacementContext?"_

I don't think we need _any_ flags in this class. We need two settings basically:
 1) "create" flag on the rule itself in the JSON - true/false
 2) "yarh.scheduler.capacity.<path>.auto-queue-creation-v2.enabled" - true/false

The placement engine (even the old one) can access both to make a decision 
about whether the queue is allowed to be created or not. If it is, it returns 
the full path inside the "ApplicationPlacementContext". Otherwise it decides 
what to do by checking the "fallbackResult" setting of the rule: returns 
"root.default", proceeds to the next rule or rejects the application.

In fact, Gergo told me that *the new engine already works the way I proposed*. 
We don't need any additional input or flag to make an explicit, valid decision 
about the placement.

Also, [~gandras] + [~snemeth] reached the same conclusion.

> Update queue creation logic to use weight mode and allow the flexible 
> static/dynamic creation
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-10506
>                 URL: https://issues.apache.org/jira/browse/YARN-10506
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Benjamin Teke
>            Assignee: Andras Gyori
>            Priority: Major
>         Attachments: YARN-10506-006-10504-010.patch, 
> YARN-10506-007-10504-010.patch, YARN-10506-008.patch, YARN-10506-010.patch, 
> YARN-10506-012.patch, YARN-10506.001.patch, YARN-10506.002.patch, 
> YARN-10506.003.patch, YARN-10506.004.patch, YARN-10506.005.patch, 
> YARN-10506.006-combined.patch, YARN-10506.006.patch, YARN-10506.007.patch, 
> YARN-10506.009.patch, YARN-10506.011.patch
>
>
> The queue creation logic should be updated to use weight mode and support the 
> flexible creation. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to