Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Julian Hyde]

Haisheng,

Thanks for the release announcement yesterday:
https://lists.apache.org/thread.html/r555d7f90568ef199c65dfddcf58b14076ac803c0dca64d945d75ba69%40%3Cannounce.apache.org%3E.
Can you also send it to dev@?

Thank you for getting those 6 PRs into master (3985, 3988, 3910, 3999,
3478, 3950). Do you think we should re-open master for commits?

Lastly, thank you for being release manager. Great job. This was a
very smooth release.

Julian

On Wed, May 27, 2020 at 12:10 PM Haisheng Yuan  wrote:
>
> Now it is back to normal:
>
> https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.23.0/
>
> On 2020/05/26 14:00:50, Haisheng Yuan  wrote:
> > Hi Enrico,
> >
> > Thanks for reporting the issue.
> >
> > I have created a JIRA ticket:
> > https://issues.apache.org/jira/browse/INFRA-20326
> >
> > Thanks,
> > Haisheng
> >
> > On 2020/05/26 09:20:14, Enrico Olivelli  wrote:
> > > Vladimir o Haisheng
> > > could you please open a ticket to INFRA ?
> > > I can do it myself, with your permission (I am not in Calcite
> > > PMC/committers group)
> > >
> > > Otherwise it is not possible to use Calcite 1.23.0 from downstream 
> > > projects
> > >
> > > Enrico
> > >
> > > Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov <
> > > sitnikov.vladi...@gmail.com> ha scritto:
> > >
> > > > ASF releases are shared with repository.apache.org:
> > > >
> > > > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom
> > > >
> > > > It might be there are issues with ASF Nexus and Sonatype Nexus sync.
> > > >
> > > > Vladimir
> > > >
> > >
> >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Now it is back to normal:

https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.23.0/

On 2020/05/26 14:00:50, Haisheng Yuan  wrote: 
> Hi Enrico,
> 
> Thanks for reporting the issue.
> 
> I have created a JIRA ticket:
> https://issues.apache.org/jira/browse/INFRA-20326
> 
> Thanks,
> Haisheng
> 
> On 2020/05/26 09:20:14, Enrico Olivelli  wrote: 
> > Vladimir o Haisheng
> > could you please open a ticket to INFRA ?
> > I can do it myself, with your permission (I am not in Calcite
> > PMC/committers group)
> > 
> > Otherwise it is not possible to use Calcite 1.23.0 from downstream projects
> > 
> > Enrico
> > 
> > Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov <
> > sitnikov.vladi...@gmail.com> ha scritto:
> > 
> > > ASF releases are shared with repository.apache.org:
> > >
> > > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom
> > >
> > > It might be there are issues with ASF Nexus and Sonatype Nexus sync.
> > >
> > > Vladimir
> > >
> > 
> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Hi Enrico,

Thanks for reporting the issue.

I have created a JIRA ticket:
https://issues.apache.org/jira/browse/INFRA-20326

Thanks,
Haisheng

On 2020/05/26 09:20:14, Enrico Olivelli  wrote: 
> Vladimir o Haisheng
> could you please open a ticket to INFRA ?
> I can do it myself, with your permission (I am not in Calcite
> PMC/committers group)
> 
> Otherwise it is not possible to use Calcite 1.23.0 from downstream projects
> 
> Enrico
> 
> Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> ha scritto:
> 
> > ASF releases are shared with repository.apache.org:
> >
> > https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom
> >
> > It might be there are issues with ASF Nexus and Sonatype Nexus sync.
> >
> > Vladimir
> >
> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Enrico Olivelli]

Vladimir o Haisheng
could you please open a ticket to INFRA ?
I can do it myself, with your permission (I am not in Calcite
PMC/committers group)

Otherwise it is not possible to use Calcite 1.23.0 from downstream projects

Enrico

Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> ha scritto:

> ASF releases are shared with repository.apache.org:
>
> https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom
>
> It might be there are issues with ASF Nexus and Sonatype Nexus sync.
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

ASF releases are shared with repository.apache.org:
https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom

It might be there are issues with ASF Nexus and Sonatype Nexus sync.

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Enrico Olivelli]

Haisheng
I still can't see Calcite 1.23.0 on Maven Central
https://search.maven.org/search?q=a:calcite-core

did the release procedure complete successfully?

Enrico



Il giorno dom 24 mag 2020 alle ore 14:35 JiaTao Tao  ha
scritto:

> Vote: +1 (non-binding)
>
> CALCITE-3819  really
> helps infinite planning in our use case. And I'm looking forward
> to CALCITE-3997.
>
> ---
> Environment: Mac-OS
> JDK version: 1.8.0_212
> Build with tests: OK
>
>
> Regards!
>
> Aron Tao
>
>
> Vladimir Sitnikov  于2020年5月24日周日 上午4:35写道：
>
> > >Looks like it is expected:
> > >https://github.com/gradle/gradle/issues/9758
> >
> > It is not expected.
> >
> > The way to fix it is to apply the following patch:
> >
> > --- a/buildSrc/build.gradle.kts
> > +++ b/buildSrc/build.gradle.kts
> > @@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
> >  import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
> >
> >  plugins {
> > -java
> >  `kotlin-dsl` apply false
> >  id("com.github.autostyle")
> >  id("com.github.vlsi.gradle-extensions")
> > @@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {
> >
> >  dependencies {
> >  subprojects.forEach {
> > -runtimeOnly(project(it.path))
> > +"runtimeOnly"(project(it.path))
> >  }
> >  }
> >
> > Vladimir
> >
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[JiaTao Tao]

Vote: +1 (non-binding)

CALCITE-3819  really
helps infinite planning in our use case. And I'm looking forward
to CALCITE-3997.

---
Environment: Mac-OS
JDK version: 1.8.0_212
Build with tests: OK


Regards!

Aron Tao


Vladimir Sitnikov  于2020年5月24日周日 上午4:35写道：

> >Looks like it is expected:
> >https://github.com/gradle/gradle/issues/9758
>
> It is not expected.
>
> The way to fix it is to apply the following patch:
>
> --- a/buildSrc/build.gradle.kts
> +++ b/buildSrc/build.gradle.kts
> @@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
>  import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
>
>  plugins {
> -java
>  `kotlin-dsl` apply false
>  id("com.github.autostyle")
>  id("com.github.vlsi.gradle-extensions")
> @@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {
>
>  dependencies {
>  subprojects.forEach {
> -runtimeOnly(project(it.path))
> +"runtimeOnly"(project(it.path))
>  }
>  }
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

>Looks like it is expected:
>https://github.com/gradle/gradle/issues/9758

It is not expected.

The way to fix it is to apply the following patch:

--- a/buildSrc/build.gradle.kts
+++ b/buildSrc/build.gradle.kts
@@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

 plugins {
-java
 `kotlin-dsl` apply false
 id("com.github.autostyle")
 id("com.github.vlsi.gradle-extensions")
@@ -75,6 +74,6 @@ fun Project.applyKotlinProjectConventions() {

 dependencies {
 subprojects.forEach {
-runtimeOnly(project(it.path))
+"runtimeOnly"(project(it.path))
 }
 }

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

> * the first line printed by gradle is ':jar: No valid plugin
> descriptors were found in META-INF/gradle-plugins'; I don't know
> whether this is bad, but it looks bad

Looks like it is expected:
https://github.com/gradle/gradle/issues/9758


On 2020/05/21 18:41:41, Julian Hyde  wrote: 
> -1 because of signature issues noted in previous email (hoping I'm mistaken).
> 
> Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT,
> compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14),
> compared contents of source distro with contents of git.
> 
> * howto.md doesn't mention JDK 14 as a valid release
> * the line 'cd calcite-1.23.0' should be 'cd apache-calcite-1.23.0-src'
> * the first line printed by gradle is ':jar: No valid plugin
> descriptors were found in META-INF/gradle-plugins'; I don't know
> whether this is bad, but it looks bad
> * following the instructions in howto.md builds a release
> '1.23.0-SNAPSHOT'; instructions should say how to build '1.23.0'
> * LICENSE file in the source distro has a few extra lines compared to
> the one in git
> * in release notes:
> ** 'fastest version of Calcite' is a bit hyperbolic; I would state
> that there have been performance improvements in the planner engine
> and hyperlink to a JIRA case
> ** I think quite a few of the 'new features' that extend an existing
> component to a new class (e.g supporting Exchange in RelFieldTrimmer)
> should be listed as bug-fixes;
> ** all class names need to be in back-ticks; all SQL keywords need to
> be upper-case and in back-ticks;
> ** I don't like the long lines - can we go back to breaking at 80?
> ** In 'it's worth mentioning the following', remove JIRA case numbers
> so that the paragraph reads like prose rather than a list.
> 
> 
> On Thu, May 21, 2020 at 10:57 AM Julian Hyde  wrote:
> >
> > Maybe I'm mistaken, but the source tarball doesn't seem to be signed:
> >
> > $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc
> > apache-calcite-1.23.0-src.tar.gz
> > gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT
> > gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF
> > gpg: Can't check signature: No public key
> >
> > I have imported Haisheng's keys successfully:
> >
> > $ gpg --recv-keys "A663 E308 27C3 5F7C F578  B4F0 41CA B58D 1DA9 7F7D"
> > gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed
> > gpg: Total number processed: 1
> > gpg:  unchanged: 1
> >
> > Julian
> >
> > On Wed, May 20, 2020 at 10:12 PM Rui Wang  wrote:
> > >
> > > I built the site both from the repo (git tag) and
> > > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot
> > > checked. From what I could tell, there wasn't an obvious difference 
> > > (random
> > > clicks were limited though).
> > >
> > > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows
> > > the exact impact of this diff, we could add it to the release note, in the
> > > category of "known issues".
> > >
> > >
> > > -Rui
> > >
> > > On Wed, May 20, 2020 at 9:33 PM Rui Wang  wrote:
> > >
> > > > Indeed there is an extra site/fonts in the git tag. I didn't see it in 
> > > > the
> > > > last two releases (the diff on licenses are normal).
> > > >
> > > > So the question is, does it matter for the diff on site/? At least the
> > > > artifact has the same source code as the tag (thus can build the same 
> > > > jar,
> > > > behave the same when run same queries, etc.) Also the site/ seems not
> > > > related to javadoc either.
> > > >
> > > >
> > > > -Rui
> > > >
> > > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis 
> > > > wrote:
> > > >
> > > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper
> > > >>
> > > >>  * Checked signatures and checksums OK
> > > >>  * Build (./gradlew clean assemble) on git repo and source artifacts OK
> > > >>  * Run unit tests (./gradlew clean test) on git repo and source 
> > > >> artifacts
> > > >> OK
> > > >>  * Run slow tests (./gradlew clean testSlow) on git repo and source
> > > >> artifacts OK
> > > >>  * Checked diff between git commit and source artifacts
> > > >> Apart from some differences in the licenses I see that the git tag has 
> > > >> a
> > > >> folder site/fonts while the source artifacts do not.
> > > >>  * Went over release note OK
> > > >>
> > > >> The following issues should be added in the breaking changes section:
> > > >> https://issues.apache.org/jira/browse/CALCITE-3825
> > > >> https://issues.apache.org/jira/browse/CALCITE-3938
> > > >>
> > > >> There are few typos and other minor improvements (like quoting SQL
> > > >> keywords
> > > >> and java classes) for the release note but all these can be done
> > > >> post-release.
> > > >>
> > > >> My only concern for casting my vote is the site/fonts folder that is
> > > >> present on the repo. I don't remember seeing this in the previous
> > > >> releases.
> > > >> Can somebody clarify if this is normal?
> > > >>
> > > >> Thanks again for your effort 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Hi Vladimir,

Thanks for your explanation.
And thanks a lot for providing such an amazing release tool for us!

Cheers,
Haisheng

On 2020/05/23 16:28:52, Vladimir Sitnikov  wrote: 
> >But it said build successful. Is there anything I can do for the 404 Not
> Found error?
> 
> It means "staging repository no longer exists as it has just been released".
> 
> I've raised https://github.com/gradle-nexus/publish-plugin/issues/29 to
> heal that.
> However, gradle-nexus/publish-plugin is not yet ready for use, so 404 will
> be there for a while.
> 
> Currently, we use https://github.com/Codearte/gradle-nexus-staging-plugin +
> https://github.com/marcphilipp/nexus-publish-plugin,
> however, I'm not eager to analyze and fix those because they both will be
> superseded by a single gradle-nexus/publish-plugin
> 
> Vladimir
> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

>But it said build successful. Is there anything I can do for the 404 Not
Found error?

It means "staging repository no longer exists as it has just been released".

I've raised https://github.com/gradle-nexus/publish-plugin/issues/29 to
heal that.
However, gradle-nexus/publish-plugin is not yet ready for use, so 404 will
be there for a while.

Currently, we use https://github.com/Codearte/gradle-nexus-staging-plugin +
https://github.com/marcphilipp/nexus-publish-plugin,
however, I'm not eager to analyze and fix those because they both will be
superseded by a single gradle-nexus/publish-plugin

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Hi,

I had the following error when executing the command:
./gradlew publishDist -Prc=1 -Pasf

> Task :releaseRepository
Initialized stagingRepositoryId orgapachecalcite-1089 for repository nexus
<==---> 50% EXECUTING [1m 17s]
GET request failed. 404: Not Found, body: [errors:[[id:*, msg:No such 
repository: orgapachecalcite-1089]]]
Requested operation was executed successfully in attempt 117 (maximum allowed 
601)

> Task :createReleaseTag
Created tag calcite-1.23.0 -> 
Ref[refs/tags/calcite-1.23.0=7c3001d97497ca60b8e2039e8f3c96ca8672fae8(-1)]

> Task :pushReleaseTag
Pushing tag to Git remote release-origin: https://github.com/apache/calcite.git
Message from release-origin:
  refs/tags/calcite-1.23.0: OK, 7c3001d97497ca60b8e2039e8f3c96ca8672fae8 
(fastForward)

BUILD SUCCESSFUL in 5m 0s
4 actionable tasks: 4 executed

~

But it said build successful. Is there anything I can do for the 404 Not Found 
error?

Thanks,
Haisheng


On 2020/05/22 20:37:35, Laurent Goujon  wrote: 
> My intent was not to cause sadness, sorry about that.
> 
> I should have elaborated a bit more why I don't think Github is that much
> of an issue:
> - LICENSE file at the root of the project is the source of truth, not
> Github mention. It is a nice to have the correct license for Github for
> sure, but it seems more important to me to have LICENSE includes the 3rd
> party dependencies present in our source tree than having the license
> displayed at the top of the github UI.
> 
> - As for the embox project you mentioned, it's probably because the license
> is short and BSD licenses have very similar texts. Here's what license says
> about the project:
> 
> $ licensee detect https://github.com/embox/embox
> License:NOASSERTION
> Matched files:  COPYRIGHT
> COPYRIGHT:
>   Content hash:  77dc7c8c10d1ed9bc1546f2d6bba18a809e235c7
>   License:   NOASSERTION
>   Closest non-matching licenses:
> BSD-2-Clause similarity:  89.59%
> BSD-3-Clause similarity:  83.54%
> BSD-4-Clause similarity:  77.82%
> 
> $ licensee license-path https://github.com/embox/embox
> COPYRIGHT
> 
> Here's now what licensee says the LICENSE file from the source distribution
> tarball:
> 
> $ licensee detect ./apache-calcite-1.23.0-src
> License:Apache-2.0
> Matched files:  LICENSE
> LICENSE:
>   Content hash:  ab3901051663cb8ee5dea9ebdff406ad136910e3
>   Confidence:100.00%
>   Matcher:   Licensee::Matchers::Exact
>   License:   Apache-2.0
> 
> $ licensee license-path ./apache-calcite-1.23.0-src
> /xxx/apache-calcite-1.23.0-src/LICENSE
> 
> It seems that adding several mentions at the bottom, licensee has no
> trouble identifying the apache license because the text is so large and so
> distinctive. It is corroborated by my own personal experience of checking
> license for many many dependencies and comparing between Maven pom.xml,
> github mention, and actual LICENSE/source file headers than when people are
> using ASL 2.0, even with copyright mention + extra stuff after the main
> text, Github gets it right.
> 
> On Fri, May 22, 2020 at 12:32 PM Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> wrote:
> 
> > Laurent>As for Github, I think this is a non-issue
> >
> > I have provided an example: https://github.com/embox/embox
> > It is an example when GitHub fails to detect the license.
> >
> > It is really sad to hear that "you think it is a non-issue" even in case
> > you have seen the failure case.
> >
> > Laurent>on the source distribution and it has no issue identifying the
> > license.
> >
> > The license might vary over time, and it would be very bad to end up with
> > improperly detected license in GitHub.
> >
> > Vladimir
> >
> 

[RESULT] [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Thanks to everyone who has tested the release candidate and given
their comments and votes.

The tally is as follows.

5 binding +1s:
Haisheng, Francis, Danny, Julian Hyde, Laurent

5 non-binding +1s:
Anton, Enrico, Feng Zhu, Xing Jin, Forward Xu

1 non-binding +0s:
Ruben Q L

Therefore I am delighted to announce that the proposal to release
Apache Calcite 1.23.0 has passed.

Thanks everyone. We’ll now roll the release out to the mirrors.

The release notes will be updated afterwards according to the feedback.

Thanks,
Haisheng

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Laurent Goujon]

My intent was not to cause sadness, sorry about that.

I should have elaborated a bit more why I don't think Github is that much
of an issue:
- LICENSE file at the root of the project is the source of truth, not
Github mention. It is a nice to have the correct license for Github for
sure, but it seems more important to me to have LICENSE includes the 3rd
party dependencies present in our source tree than having the license
displayed at the top of the github UI.

- As for the embox project you mentioned, it's probably because the license
is short and BSD licenses have very similar texts. Here's what license says
about the project:

$ licensee detect https://github.com/embox/embox
License:NOASSERTION
Matched files:  COPYRIGHT
COPYRIGHT:
  Content hash:  77dc7c8c10d1ed9bc1546f2d6bba18a809e235c7
  License:   NOASSERTION
  Closest non-matching licenses:
BSD-2-Clause similarity:  89.59%
BSD-3-Clause similarity:  83.54%
BSD-4-Clause similarity:  77.82%

$ licensee license-path https://github.com/embox/embox
COPYRIGHT

Here's now what licensee says the LICENSE file from the source distribution
tarball:

$ licensee detect ./apache-calcite-1.23.0-src
License:Apache-2.0
Matched files:  LICENSE
LICENSE:
  Content hash:  ab3901051663cb8ee5dea9ebdff406ad136910e3
  Confidence:100.00%
  Matcher:   Licensee::Matchers::Exact
  License:   Apache-2.0

$ licensee license-path ./apache-calcite-1.23.0-src
/xxx/apache-calcite-1.23.0-src/LICENSE

It seems that adding several mentions at the bottom, licensee has no
trouble identifying the apache license because the text is so large and so
distinctive. It is corroborated by my own personal experience of checking
license for many many dependencies and comparing between Maven pom.xml,
github mention, and actual LICENSE/source file headers than when people are
using ASL 2.0, even with copyright mention + extra stuff after the main
text, Github gets it right.

On Fri, May 22, 2020 at 12:32 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Laurent>As for Github, I think this is a non-issue
>
> I have provided an example: https://github.com/embox/embox
> It is an example when GitHub fails to detect the license.
>
> It is really sad to hear that "you think it is a non-issue" even in case
> you have seen the failure case.
>
> Laurent>on the source distribution and it has no issue identifying the
> license.
>
> The license might vary over time, and it would be very bad to end up with
> improperly detected license in GitHub.
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

Laurent>As for Github, I think this is a non-issue

I have provided an example: https://github.com/embox/embox
It is an example when GitHub fails to detect the license.

It is really sad to hear that "you think it is a non-issue" even in case
you have seen the failure case.

Laurent>on the source distribution and it has no issue identifying the
license.

The license might vary over time, and it would be very bad to end up with
improperly detected license in GitHub.

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Laurent Goujon]

Vote: +1 (binding)

- Local Calcite builds (./gradlew clean build && ./gradlew testSlow) on
MacOS and JDK8/11/14: OK
- tarball content and signature: OK

On Fri, May 15, 2020 at 9:02 PM Haisheng Yuan  wrote:

> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> (revision 39622)
>
> The hashes of the artifacts are as follows:
>
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> *apache-calcite-1.23.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/release/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.23.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.23.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Laurent Goujon]

I meant the source distribution here.

I guess I didn't realize Calcite source tree has embedded copies of some
3rd party css/js, but since those are not fetched dynamically and are part
of the source tree, I think the committed LICENCE file should include those
vs altering it at release time. As for Github, I think this is a non-issue
because I've seen lots of variations on the LICENSE file, and github seems
pretty lenient about it. I actually tried licensee (
https://github.com/licensee/licensee, used by Github itself) on the source
distribution and it has no issue identifying the license.

Also, although jekyll, is mentioned as a dependency, I don't see it
bundled, and because there's no version associated with it, the license
file is under licenses/jekyll-.

On Fri, May 22, 2020 at 9:34 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in
> LICENSE
> Laurent> bundled with the distribution?
>
> Which distribution do you mean?
> Of course, Calcite source release bundles third-party dependencies (e.g.
> site/js/*.js files).
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

My keys are signed by Stamatis, thanks for helping, Stamatis!

Now the keys link worked, 
https://people.apache.org/keys/committer/hyuan.asc

No more action is needed, Julian.

Thanks,
Haisheng

On 2020/05/22 00:25:15, Julian Hyde  wrote: 
> OK, I imported Haisheng's key from KEYS and now it checks out. The
> message "no public key" was confusing - I thought it meant that the
> file was not signed, whereas gpg meant that it did not recognize the
> key.
> 
> Changing my vote to +1.
> 
> Haisheng, can you please get one or two people to sign your key, so
> that you are in the web of trust. It does not need to happen before
> the release, but before we announce.
> 
> The difference in LICENSE is concerning because this is a source
> distro. All files should match those in the source repo at that
> precise commit. Could this version of LICENSE be the committed one?
> 
> Julian
> 
> 
> On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov
>  wrote:
> >
> > >-1 because of signature issues noted in previous email (hoping I'm
> > mistaken).
> >
> > I think you are confused because Haisheng uses multiple keys.
> > https://people.apache.org/keys/committer/ lists two keys, and
> > https://dist.apache.org/repos/dist/release/calcite/KEYS does include the
> > key that signs the release (ECA9...).
> >
> > Please double-check.
> >
> > >* LICENSE file in the source distro has a few extra lines compared to
> > the one in git
> >
> > I see lots of people list the difference. What do you expect?
> > If the difference is ok, then why list it?
> > If the difference is not ok, then where is the reasoning?
> >
> > Vladimir
> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in
LICENSE
Laurent> bundled with the distribution?

Which distribution do you mean?
Of course, Calcite source release bundles third-party dependencies (e.g.
site/js/*.js files).

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Laurent Goujon]

I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE
bundled with the distribution?

On Fri, May 22, 2020 at 12:45 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Julian>It does not need to happen before
> Julian>the release, but before we announce.
>
> Cross-signing is not required at all.
>
> Julian>All files should match those in the source repo at that
> Julian>precise commit.
> Julian> Could this version of LICENSE be the committed one?
>
> Long story short: LICENSE file is a build artifact rather than an opaque
> blob.
>
> The license for the release artifact must include the licenses of all the
> bundled dependencies.
> That becomes extremely fragile if the license text is maintained manually.
>
> In the past there were multiple license violations in both Calcite and
> Calcite Avatica releases.
> The violations included: "missing license, copyright", "forbidden
> dependency bundled in the release".
>
> ---
>
> GitHub uses /LICENSE file to show the repository license in the summary
> line (right above the source tree),
> so adding extra content might confuse GitHub which would be devastating.
>
> Here's a sample project: https://github.com/embox/embox
> The license is BSD-2-Clause, however, GitHub is confused, and it shows
> "view license" rather than "BSD-2-Clause"
>
> ---
>
> It might be worth including the expected contents of the "release license"
> under /src/*/test/resources/EXPECTED_LICENSE
> It would protect from unexpected third-party dependencies bundling.
> As usual, PRs are welcome.
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

Julian>It does not need to happen before
Julian>the release, but before we announce.

Cross-signing is not required at all.

Julian>All files should match those in the source repo at that
Julian>precise commit.
Julian> Could this version of LICENSE be the committed one?

Long story short: LICENSE file is a build artifact rather than an opaque
blob.

The license for the release artifact must include the licenses of all the
bundled dependencies.
That becomes extremely fragile if the license text is maintained manually.

In the past there were multiple license violations in both Calcite and
Calcite Avatica releases.
The violations included: "missing license, copyright", "forbidden
dependency bundled in the release".

---

GitHub uses /LICENSE file to show the repository license in the summary
line (right above the source tree),
so adding extra content might confuse GitHub which would be devastating.

Here's a sample project: https://github.com/embox/embox
The license is BSD-2-Clause, however, GitHub is confused, and it shows
"view license" rather than "BSD-2-Clause"

---

It might be worth including the expected contents of the "release license"
under /src/*/test/resources/EXPECTED_LICENSE
It would protect from unexpected third-party dependencies bundling.
As usual, PRs are welcome.

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Thanks.

To Julian and Stamatis,
Can you help sign my keys?

3CD22ABAC50DDCEF
41CAB58D1DA97F7D

We can hangout if it is required.

Thanks,
Haisheng

On 2020/05/22 00:25:15, Julian Hyde  wrote: 
> OK, I imported Haisheng's key from KEYS and now it checks out. The
> message "no public key" was confusing - I thought it meant that the
> file was not signed, whereas gpg meant that it did not recognize the
> key.
> 
> Changing my vote to +1.
> 
> Haisheng, can you please get one or two people to sign your key, so
> that you are in the web of trust. It does not need to happen before
> the release, but before we announce.
> 
> The difference in LICENSE is concerning because this is a source
> distro. All files should match those in the source repo at that
> precise commit. Could this version of LICENSE be the committed one?
> 
> Julian
> 
> 
> On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov
>  wrote:
> >
> > >-1 because of signature issues noted in previous email (hoping I'm
> > mistaken).
> >
> > I think you are confused because Haisheng uses multiple keys.
> > https://people.apache.org/keys/committer/ lists two keys, and
> > https://dist.apache.org/repos/dist/release/calcite/KEYS does include the
> > key that signs the release (ECA9...).
> >
> > Please double-check.
> >
> > >* LICENSE file in the source distro has a few extra lines compared to
> > the one in git
> >
> > I see lots of people list the difference. What do you expect?
> > If the difference is ok, then why list it?
> > If the difference is not ok, then where is the reasoning?
> >
> > Vladimir
> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Julian Hyde]

OK, I imported Haisheng's key from KEYS and now it checks out. The
message "no public key" was confusing - I thought it meant that the
file was not signed, whereas gpg meant that it did not recognize the
key.

Changing my vote to +1.

Haisheng, can you please get one or two people to sign your key, so
that you are in the web of trust. It does not need to happen before
the release, but before we announce.

The difference in LICENSE is concerning because this is a source
distro. All files should match those in the source repo at that
precise commit. Could this version of LICENSE be the committed one?

Julian


On Thu, May 21, 2020 at 12:08 PM Vladimir Sitnikov
 wrote:
>
> >-1 because of signature issues noted in previous email (hoping I'm
> mistaken).
>
> I think you are confused because Haisheng uses multiple keys.
> https://people.apache.org/keys/committer/ lists two keys, and
> https://dist.apache.org/repos/dist/release/calcite/KEYS does include the
> key that signs the release (ECA9...).
>
> Please double-check.
>
> >* LICENSE file in the source distro has a few extra lines compared to
> the one in git
>
> I see lots of people list the difference. What do you expect?
> If the difference is ok, then why list it?
> If the difference is not ok, then where is the reasoning?
>
> Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Vladimir Sitnikov]

>-1 because of signature issues noted in previous email (hoping I'm
mistaken).

I think you are confused because Haisheng uses multiple keys.
https://people.apache.org/keys/committer/ lists two keys, and
https://dist.apache.org/repos/dist/release/calcite/KEYS does include the
key that signs the release (ECA9...).

Please double-check.

>* LICENSE file in the source distro has a few extra lines compared to
the one in git

I see lots of people list the difference. What do you expect?
If the difference is ok, then why list it?
If the difference is not ok, then where is the reasoning?

Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Julian Hyde]

-1 because of signature issues noted in previous email (hoping I'm mistaken).

Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT,
compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14),
compared contents of source distro with contents of git.

* howto.md doesn't mention JDK 14 as a valid release
* the line 'cd calcite-1.23.0' should be 'cd apache-calcite-1.23.0-src'
* the first line printed by gradle is ':jar: No valid plugin
descriptors were found in META-INF/gradle-plugins'; I don't know
whether this is bad, but it looks bad
* following the instructions in howto.md builds a release
'1.23.0-SNAPSHOT'; instructions should say how to build '1.23.0'
* LICENSE file in the source distro has a few extra lines compared to
the one in git
* in release notes:
** 'fastest version of Calcite' is a bit hyperbolic; I would state
that there have been performance improvements in the planner engine
and hyperlink to a JIRA case
** I think quite a few of the 'new features' that extend an existing
component to a new class (e.g supporting Exchange in RelFieldTrimmer)
should be listed as bug-fixes;
** all class names need to be in back-ticks; all SQL keywords need to
be upper-case and in back-ticks;
** I don't like the long lines - can we go back to breaking at 80?
** In 'it's worth mentioning the following', remove JIRA case numbers
so that the paragraph reads like prose rather than a list.


On Thu, May 21, 2020 at 10:57 AM Julian Hyde  wrote:
>
> Maybe I'm mistaken, but the source tarball doesn't seem to be signed:
>
> $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc
> apache-calcite-1.23.0-src.tar.gz
> gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT
> gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF
> gpg: Can't check signature: No public key
>
> I have imported Haisheng's keys successfully:
>
> $ gpg --recv-keys "A663 E308 27C3 5F7C F578  B4F0 41CA B58D 1DA9 7F7D"
> gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed
> gpg: Total number processed: 1
> gpg:  unchanged: 1
>
> Julian
>
> On Wed, May 20, 2020 at 10:12 PM Rui Wang  wrote:
> >
> > I built the site both from the repo (git tag) and
> > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot
> > checked. From what I could tell, there wasn't an obvious difference (random
> > clicks were limited though).
> >
> > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows
> > the exact impact of this diff, we could add it to the release note, in the
> > category of "known issues".
> >
> >
> > -Rui
> >
> > On Wed, May 20, 2020 at 9:33 PM Rui Wang  wrote:
> >
> > > Indeed there is an extra site/fonts in the git tag. I didn't see it in the
> > > last two releases (the diff on licenses are normal).
> > >
> > > So the question is, does it matter for the diff on site/? At least the
> > > artifact has the same source code as the tag (thus can build the same jar,
> > > behave the same when run same queries, etc.) Also the site/ seems not
> > > related to javadoc either.
> > >
> > >
> > > -Rui
> > >
> > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis 
> > > wrote:
> > >
> > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper
> > >>
> > >>  * Checked signatures and checksums OK
> > >>  * Build (./gradlew clean assemble) on git repo and source artifacts OK
> > >>  * Run unit tests (./gradlew clean test) on git repo and source artifacts
> > >> OK
> > >>  * Run slow tests (./gradlew clean testSlow) on git repo and source
> > >> artifacts OK
> > >>  * Checked diff between git commit and source artifacts
> > >> Apart from some differences in the licenses I see that the git tag has a
> > >> folder site/fonts while the source artifacts do not.
> > >>  * Went over release note OK
> > >>
> > >> The following issues should be added in the breaking changes section:
> > >> https://issues.apache.org/jira/browse/CALCITE-3825
> > >> https://issues.apache.org/jira/browse/CALCITE-3938
> > >>
> > >> There are few typos and other minor improvements (like quoting SQL
> > >> keywords
> > >> and java classes) for the release note but all these can be done
> > >> post-release.
> > >>
> > >> My only concern for casting my vote is the site/fonts folder that is
> > >> present on the repo. I don't remember seeing this in the previous
> > >> releases.
> > >> Can somebody clarify if this is normal?
> > >>
> > >> Thanks again for your effort Haisheng!
> > >>
> > >> Best,
> > >> Stamatis
> > >>
> > >> On Wed, May 20, 2020 at 3:13 PM Danny Chan  wrote:
> > >>
> > >> > Thanks Haisheng for driving this!
> > >> >
> > >> > Verified GPG signature - OK
> > >> > Verified SHA512 - OK
> > >> > Release notes - OK
> > >> > Diff the files in the release artifact and tag - ok
> > >> >
> > >> > As for Calcite 3997, it only affects the Physical node,  I’m fine with
> > >> that
> > >> > ~
> > >> >
> > >> > So +1 (binding) ~
> > >> >
> > >> > Gradle 6.3 (via gradlew)
> > >> > Mac OS High Sierra
> > >> > 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Julian Hyde]

Maybe I'm mistaken, but the source tarball doesn't seem to be signed:

$ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc
apache-calcite-1.23.0-src.tar.gz
gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT
gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF
gpg: Can't check signature: No public key

I have imported Haisheng's keys successfully:

$ gpg --recv-keys "A663 E308 27C3 5F7C F578  B4F0 41CA B58D 1DA9 7F7D"
gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan " not changed
gpg: Total number processed: 1
gpg:  unchanged: 1

Julian

On Wed, May 20, 2020 at 10:12 PM Rui Wang  wrote:
>
> I built the site both from the repo (git tag) and
> apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot
> checked. From what I could tell, there wasn't an obvious difference (random
> clicks were limited though).
>
> My personal opinion is that the 1.23.0 rc1 can continue. If someone knows
> the exact impact of this diff, we could add it to the release note, in the
> category of "known issues".
>
>
> -Rui
>
> On Wed, May 20, 2020 at 9:33 PM Rui Wang  wrote:
>
> > Indeed there is an extra site/fonts in the git tag. I didn't see it in the
> > last two releases (the diff on licenses are normal).
> >
> > So the question is, does it matter for the diff on site/? At least the
> > artifact has the same source code as the tag (thus can build the same jar,
> > behave the same when run same queries, etc.) Also the site/ seems not
> > related to javadoc either.
> >
> >
> > -Rui
> >
> > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis 
> > wrote:
> >
> >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper
> >>
> >>  * Checked signatures and checksums OK
> >>  * Build (./gradlew clean assemble) on git repo and source artifacts OK
> >>  * Run unit tests (./gradlew clean test) on git repo and source artifacts
> >> OK
> >>  * Run slow tests (./gradlew clean testSlow) on git repo and source
> >> artifacts OK
> >>  * Checked diff between git commit and source artifacts
> >> Apart from some differences in the licenses I see that the git tag has a
> >> folder site/fonts while the source artifacts do not.
> >>  * Went over release note OK
> >>
> >> The following issues should be added in the breaking changes section:
> >> https://issues.apache.org/jira/browse/CALCITE-3825
> >> https://issues.apache.org/jira/browse/CALCITE-3938
> >>
> >> There are few typos and other minor improvements (like quoting SQL
> >> keywords
> >> and java classes) for the release note but all these can be done
> >> post-release.
> >>
> >> My only concern for casting my vote is the site/fonts folder that is
> >> present on the repo. I don't remember seeing this in the previous
> >> releases.
> >> Can somebody clarify if this is normal?
> >>
> >> Thanks again for your effort Haisheng!
> >>
> >> Best,
> >> Stamatis
> >>
> >> On Wed, May 20, 2020 at 3:13 PM Danny Chan  wrote:
> >>
> >> > Thanks Haisheng for driving this!
> >> >
> >> > Verified GPG signature - OK
> >> > Verified SHA512 - OK
> >> > Release notes - OK
> >> > Diff the files in the release artifact and tag - ok
> >> >
> >> > As for Calcite 3997, it only affects the Physical node,  I’m fine with
> >> that
> >> > ~
> >> >
> >> > So +1 (binding) ~
> >> >
> >> > Gradle 6.3 (via gradlew)
> >> > Mac OS High Sierra
> >> > JDK version "1.8.0_151"
> >> >
> >> > Forward Xu 于2020年5月20日 周三上午9:38写道：
> >> >
> >> > > Thanks, Haisheng!
> >> > >
> >> > >
> >> > > Environment: Mac-OS Mojave (10.14.6)
> >> > >
> >> > > JDK version: 1.8.0_211
> >> > >
> >> > >
> >> > > Release notes: OK
> >> > >
> >> > > Build with tests: OK
> >> > >
> >> > > Checksums and signatures: OK
> >> > >
> >> > >
> >> > > Vote:
> >> > >
> >> > > +1 (non-binding)
> >> > >
> >> > >
> >> > > Best,
> >> > >
> >> > > Forward
> >> > >
> >> > > XING JIN  于2020年5月19日周二 上午10:53写道：
> >> > >
> >> > > > Thanks, Haisheng ~
> >> > > >
> >> > > > Local Calcite build with tests enabled on Linux: *OK*
> >> > > > Calcite-based system test suite: *OK*
> >> > > >
> >> > > > Vote:
> >> > > > +1 (non-binding)
> >> > > >
> >> > > > Francis Chuang  于2020年5月18日周一 下午2:00写道：
> >> > > >
> >> > > > > Thanks for making this release available for voting, Haisheng!
> >> > > > >
> >> > > > > Verified GPG signature - OK
> >> > > > > Verified SHA512 - OK
> >> > > > > Ran tests per HOWTO (./gradlew check) - OK
> >> > > > > Quickly skimmed release notes - OK
> >> > > > > Spotted checked a few JARs in the Maven repository - OK
> >> > > > >
> >> > > > > Environment (OpenJDK:latest docker container):
> >> > > > > Gradle 6.3 (via gradlew)
> >> > > > > Debian GNU/Linux 8
> >> > > > > openjdk version "1.8.0_111"
> >> > > > > OpenJDK Runtime Environment (build
> >> 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> >> > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> >> > > > >
> >> > > > > My vote is: +1 (binding)
> >> > > > >
> >> > > > > Francis
> >> > > > >
> >> > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> >> > > > > > 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Rui Wang]

I built the site both from the repo (git tag) and
apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot
checked. From what I could tell, there wasn't an obvious difference (random
clicks were limited though).

My personal opinion is that the 1.23.0 rc1 can continue. If someone knows
the exact impact of this diff, we could add it to the release note, in the
category of "known issues".


-Rui

On Wed, May 20, 2020 at 9:33 PM Rui Wang  wrote:

> Indeed there is an extra site/fonts in the git tag. I didn't see it in the
> last two releases (the diff on licenses are normal).
>
> So the question is, does it matter for the diff on site/? At least the
> artifact has the same source code as the tag (thus can build the same jar,
> behave the same when run same queries, etc.) Also the site/ seems not
> related to javadoc either.
>
>
> -Rui
>
> On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis 
> wrote:
>
>> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper
>>
>>  * Checked signatures and checksums OK
>>  * Build (./gradlew clean assemble) on git repo and source artifacts OK
>>  * Run unit tests (./gradlew clean test) on git repo and source artifacts
>> OK
>>  * Run slow tests (./gradlew clean testSlow) on git repo and source
>> artifacts OK
>>  * Checked diff between git commit and source artifacts
>> Apart from some differences in the licenses I see that the git tag has a
>> folder site/fonts while the source artifacts do not.
>>  * Went over release note OK
>>
>> The following issues should be added in the breaking changes section:
>> https://issues.apache.org/jira/browse/CALCITE-3825
>> https://issues.apache.org/jira/browse/CALCITE-3938
>>
>> There are few typos and other minor improvements (like quoting SQL
>> keywords
>> and java classes) for the release note but all these can be done
>> post-release.
>>
>> My only concern for casting my vote is the site/fonts folder that is
>> present on the repo. I don't remember seeing this in the previous
>> releases.
>> Can somebody clarify if this is normal?
>>
>> Thanks again for your effort Haisheng!
>>
>> Best,
>> Stamatis
>>
>> On Wed, May 20, 2020 at 3:13 PM Danny Chan  wrote:
>>
>> > Thanks Haisheng for driving this!
>> >
>> > Verified GPG signature - OK
>> > Verified SHA512 - OK
>> > Release notes - OK
>> > Diff the files in the release artifact and tag - ok
>> >
>> > As for Calcite 3997, it only affects the Physical node,  I’m fine with
>> that
>> > ~
>> >
>> > So +1 (binding) ~
>> >
>> > Gradle 6.3 (via gradlew)
>> > Mac OS High Sierra
>> > JDK version "1.8.0_151"
>> >
>> > Forward Xu 于2020年5月20日 周三上午9:38写道：
>> >
>> > > Thanks, Haisheng!
>> > >
>> > >
>> > > Environment: Mac-OS Mojave (10.14.6)
>> > >
>> > > JDK version: 1.8.0_211
>> > >
>> > >
>> > > Release notes: OK
>> > >
>> > > Build with tests: OK
>> > >
>> > > Checksums and signatures: OK
>> > >
>> > >
>> > > Vote:
>> > >
>> > > +1 (non-binding)
>> > >
>> > >
>> > > Best,
>> > >
>> > > Forward
>> > >
>> > > XING JIN  于2020年5月19日周二 上午10:53写道：
>> > >
>> > > > Thanks, Haisheng ~
>> > > >
>> > > > Local Calcite build with tests enabled on Linux: *OK*
>> > > > Calcite-based system test suite: *OK*
>> > > >
>> > > > Vote:
>> > > > +1 (non-binding)
>> > > >
>> > > > Francis Chuang  于2020年5月18日周一 下午2:00写道：
>> > > >
>> > > > > Thanks for making this release available for voting, Haisheng!
>> > > > >
>> > > > > Verified GPG signature - OK
>> > > > > Verified SHA512 - OK
>> > > > > Ran tests per HOWTO (./gradlew check) - OK
>> > > > > Quickly skimmed release notes - OK
>> > > > > Spotted checked a few JARs in the Maven repository - OK
>> > > > >
>> > > > > Environment (OpenJDK:latest docker container):
>> > > > > Gradle 6.3 (via gradlew)
>> > > > > Debian GNU/Linux 8
>> > > > > openjdk version "1.8.0_111"
>> > > > > OpenJDK Runtime Environment (build
>> 1.8.0_111-8u111-b14-2~bpo8+1-b14)
>> > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
>> > > > >
>> > > > > My vote is: +1 (binding)
>> > > > >
>> > > > > Francis
>> > > > >
>> > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
>> > > > > > Hi all,
>> > > > > >
>> > > > > > I have created a build for Apache Calcite 1.23.0, release
>> > > > > > candidate 1.
>> > > > > >
>> > > > > > Thanks to everyone who has contributed to this release.
>> > > > > >
>> > > > > > You can read the release notes here:
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>> > > > > >
>> > > > > > The commit to be voted upon:
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>> > > > > >
>> > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>> > > > > >
>> > > > > > Tag:
>> > > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>> > > > > >
>> > > > > > The artifacts to be voted on are located here:
>> > > > > >
>> > > >
>> >
>> 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Rui Wang]

Indeed there is an extra site/fonts in the git tag. I didn't see it in the
last two releases (the diff on licenses are normal).

So the question is, does it matter for the diff on site/? At least the
artifact has the same source code as the tag (thus can build the same jar,
behave the same when run same queries, etc.) Also the site/ seems not
related to javadoc either.


-Rui

On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis 
wrote:

> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper
>
>  * Checked signatures and checksums OK
>  * Build (./gradlew clean assemble) on git repo and source artifacts OK
>  * Run unit tests (./gradlew clean test) on git repo and source artifacts
> OK
>  * Run slow tests (./gradlew clean testSlow) on git repo and source
> artifacts OK
>  * Checked diff between git commit and source artifacts
> Apart from some differences in the licenses I see that the git tag has a
> folder site/fonts while the source artifacts do not.
>  * Went over release note OK
>
> The following issues should be added in the breaking changes section:
> https://issues.apache.org/jira/browse/CALCITE-3825
> https://issues.apache.org/jira/browse/CALCITE-3938
>
> There are few typos and other minor improvements (like quoting SQL keywords
> and java classes) for the release note but all these can be done
> post-release.
>
> My only concern for casting my vote is the site/fonts folder that is
> present on the repo. I don't remember seeing this in the previous releases.
> Can somebody clarify if this is normal?
>
> Thanks again for your effort Haisheng!
>
> Best,
> Stamatis
>
> On Wed, May 20, 2020 at 3:13 PM Danny Chan  wrote:
>
> > Thanks Haisheng for driving this!
> >
> > Verified GPG signature - OK
> > Verified SHA512 - OK
> > Release notes - OK
> > Diff the files in the release artifact and tag - ok
> >
> > As for Calcite 3997, it only affects the Physical node,  I’m fine with
> that
> > ~
> >
> > So +1 (binding) ~
> >
> > Gradle 6.3 (via gradlew)
> > Mac OS High Sierra
> > JDK version "1.8.0_151"
> >
> > Forward Xu 于2020年5月20日 周三上午9:38写道：
> >
> > > Thanks, Haisheng!
> > >
> > >
> > > Environment: Mac-OS Mojave (10.14.6)
> > >
> > > JDK version: 1.8.0_211
> > >
> > >
> > > Release notes: OK
> > >
> > > Build with tests: OK
> > >
> > > Checksums and signatures: OK
> > >
> > >
> > > Vote:
> > >
> > > +1 (non-binding)
> > >
> > >
> > > Best,
> > >
> > > Forward
> > >
> > > XING JIN  于2020年5月19日周二 上午10:53写道：
> > >
> > > > Thanks, Haisheng ~
> > > >
> > > > Local Calcite build with tests enabled on Linux: *OK*
> > > > Calcite-based system test suite: *OK*
> > > >
> > > > Vote:
> > > > +1 (non-binding)
> > > >
> > > > Francis Chuang  于2020年5月18日周一 下午2:00写道：
> > > >
> > > > > Thanks for making this release available for voting, Haisheng!
> > > > >
> > > > > Verified GPG signature - OK
> > > > > Verified SHA512 - OK
> > > > > Ran tests per HOWTO (./gradlew check) - OK
> > > > > Quickly skimmed release notes - OK
> > > > > Spotted checked a few JARs in the Maven repository - OK
> > > > >
> > > > > Environment (OpenJDK:latest docker container):
> > > > > Gradle 6.3 (via gradlew)
> > > > > Debian GNU/Linux 8
> > > > > openjdk version "1.8.0_111"
> > > > > OpenJDK Runtime Environment (build
> 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> > > > >
> > > > > My vote is: +1 (binding)
> > > > >
> > > > > Francis
> > > > >
> > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > I have created a build for Apache Calcite 1.23.0, release
> > > > > > candidate 1.
> > > > > >
> > > > > > Thanks to everyone who has contributed to this release.
> > > > > >
> > > > > > You can read the release notes here:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > > > > >
> > > > > > The commit to be voted upon:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > > > >
> > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > > > >
> > > > > > Tag:
> > > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > > > > >
> > > > > > The artifacts to be voted on are located here:
> > > > > >
> > > >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > > > > (revision 39622)
> > > > > >
> > > > > > The hashes of the artifacts are as follows:
> > > > > >
> > > > >
> > > >
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > > > > *apache-calcite-1.23.0-src.tar.gz
> > > > > >
> > > > > > A staged Maven repository is available for review at:
> > > > > >
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > > > > >
> > > > > > Release artifacts are 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Stamatis Zampetakis]

5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper

 * Checked signatures and checksums OK
 * Build (./gradlew clean assemble) on git repo and source artifacts OK
 * Run unit tests (./gradlew clean test) on git repo and source artifacts OK
 * Run slow tests (./gradlew clean testSlow) on git repo and source
artifacts OK
 * Checked diff between git commit and source artifacts
Apart from some differences in the licenses I see that the git tag has a
folder site/fonts while the source artifacts do not.
 * Went over release note OK

The following issues should be added in the breaking changes section:
https://issues.apache.org/jira/browse/CALCITE-3825
https://issues.apache.org/jira/browse/CALCITE-3938

There are few typos and other minor improvements (like quoting SQL keywords
and java classes) for the release note but all these can be done
post-release.

My only concern for casting my vote is the site/fonts folder that is
present on the repo. I don't remember seeing this in the previous releases.
Can somebody clarify if this is normal?

Thanks again for your effort Haisheng!

Best,
Stamatis

On Wed, May 20, 2020 at 3:13 PM Danny Chan  wrote:

> Thanks Haisheng for driving this!
>
> Verified GPG signature - OK
> Verified SHA512 - OK
> Release notes - OK
> Diff the files in the release artifact and tag - ok
>
> As for Calcite 3997, it only affects the Physical node,  I’m fine with that
> ~
>
> So +1 (binding) ~
>
> Gradle 6.3 (via gradlew)
> Mac OS High Sierra
> JDK version "1.8.0_151"
>
> Forward Xu 于2020年5月20日 周三上午9:38写道：
>
> > Thanks, Haisheng!
> >
> >
> > Environment: Mac-OS Mojave (10.14.6)
> >
> > JDK version: 1.8.0_211
> >
> >
> > Release notes: OK
> >
> > Build with tests: OK
> >
> > Checksums and signatures: OK
> >
> >
> > Vote:
> >
> > +1 (non-binding)
> >
> >
> > Best,
> >
> > Forward
> >
> > XING JIN  于2020年5月19日周二 上午10:53写道：
> >
> > > Thanks, Haisheng ~
> > >
> > > Local Calcite build with tests enabled on Linux: *OK*
> > > Calcite-based system test suite: *OK*
> > >
> > > Vote:
> > > +1 (non-binding)
> > >
> > > Francis Chuang  于2020年5月18日周一 下午2:00写道：
> > >
> > > > Thanks for making this release available for voting, Haisheng!
> > > >
> > > > Verified GPG signature - OK
> > > > Verified SHA512 - OK
> > > > Ran tests per HOWTO (./gradlew check) - OK
> > > > Quickly skimmed release notes - OK
> > > > Spotted checked a few JARs in the Maven repository - OK
> > > >
> > > > Environment (OpenJDK:latest docker container):
> > > > Gradle 6.3 (via gradlew)
> > > > Debian GNU/Linux 8
> > > > openjdk version "1.8.0_111"
> > > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> > > >
> > > > My vote is: +1 (binding)
> > > >
> > > > Francis
> > > >
> > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > > > > Hi all,
> > > > >
> > > > > I have created a build for Apache Calcite 1.23.0, release
> > > > > candidate 1.
> > > > >
> > > > > Thanks to everyone who has contributed to this release.
> > > > >
> > > > > You can read the release notes here:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > > > >
> > > > > The commit to be voted upon:
> > > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > > >
> > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > > >
> > > > > Tag:
> > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > > > >
> > > > > The artifacts to be voted on are located here:
> > > > >
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > > > (revision 39622)
> > > > >
> > > > > The hashes of the artifacts are as follows:
> > > > >
> > > >
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > > > *apache-calcite-1.23.0-src.tar.gz
> > > > >
> > > > > A staged Maven repository is available for review at:
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > > > >
> > > > > Release artifacts are signed with the following key:
> > > > > https://dist.apache.org/repos/dist/release/calcite/KEYS
> > > > >
> > > > > N.B.
> > > > > To create the jars and test Apache Calcite: "./gradlew build".
> > > > >
> > > > > If you do not have a Java environment available, you can run the
> > tests
> > > > > using docker. To do so, install docker and docker-compose, then run
> > > > > "docker-compose run test" from the root of the directory.
> > > > >
> > > > > Please vote on releasing this package as Apache Calcite 1.23.0.
> > > > >
> > > > > The vote is open for the next 72 hours and passes if a majority of
> at
> > > > > least three +1 PMC votes are cast.
> > > > >
> > > > > [ ] +1 Release this package as Apache Calcite 1.23.0
> > > > > [ ]  0 I don't 

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Danny Chan]

Thanks Haisheng for driving this!

Verified GPG signature - OK
Verified SHA512 - OK
Release notes - OK
Diff the files in the release artifact and tag - ok

As for Calcite 3997, it only affects the Physical node,  I’m fine with that
~

So +1 (binding) ~

Gradle 6.3 (via gradlew)
Mac OS High Sierra
JDK version "1.8.0_151"

Forward Xu 于2020年5月20日 周三上午9:38写道：

> Thanks, Haisheng!
>
>
> Environment: Mac-OS Mojave (10.14.6)
>
> JDK version: 1.8.0_211
>
>
> Release notes: OK
>
> Build with tests: OK
>
> Checksums and signatures: OK
>
>
> Vote:
>
> +1 (non-binding)
>
>
> Best,
>
> Forward
>
> XING JIN  于2020年5月19日周二 上午10:53写道：
>
> > Thanks, Haisheng ~
> >
> > Local Calcite build with tests enabled on Linux: *OK*
> > Calcite-based system test suite: *OK*
> >
> > Vote:
> > +1 (non-binding)
> >
> > Francis Chuang  于2020年5月18日周一 下午2:00写道：
> >
> > > Thanks for making this release available for voting, Haisheng!
> > >
> > > Verified GPG signature - OK
> > > Verified SHA512 - OK
> > > Ran tests per HOWTO (./gradlew check) - OK
> > > Quickly skimmed release notes - OK
> > > Spotted checked a few JARs in the Maven repository - OK
> > >
> > > Environment (OpenJDK:latest docker container):
> > > Gradle 6.3 (via gradlew)
> > > Debian GNU/Linux 8
> > > openjdk version "1.8.0_111"
> > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> > >
> > > My vote is: +1 (binding)
> > >
> > > Francis
> > >
> > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > > > Hi all,
> > > >
> > > > I have created a build for Apache Calcite 1.23.0, release
> > > > candidate 1.
> > > >
> > > > Thanks to everyone who has contributed to this release.
> > > >
> > > > You can read the release notes here:
> > > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > > >
> > > > The commit to be voted upon:
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > >
> > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > >
> > > > Tag:
> > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > > >
> > > > The artifacts to be voted on are located here:
> > > >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > > (revision 39622)
> > > >
> > > > The hashes of the artifacts are as follows:
> > > >
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > > *apache-calcite-1.23.0-src.tar.gz
> > > >
> > > > A staged Maven repository is available for review at:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > > >
> > > > Release artifacts are signed with the following key:
> > > > https://dist.apache.org/repos/dist/release/calcite/KEYS
> > > >
> > > > N.B.
> > > > To create the jars and test Apache Calcite: "./gradlew build".
> > > >
> > > > If you do not have a Java environment available, you can run the
> tests
> > > > using docker. To do so, install docker and docker-compose, then run
> > > > "docker-compose run test" from the root of the directory.
> > > >
> > > > Please vote on releasing this package as Apache Calcite 1.23.0.
> > > >
> > > > The vote is open for the next 72 hours and passes if a majority of at
> > > > least three +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Calcite 1.23.0
> > > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > > >
> > > > Here is my vote:
> > > >
> > > > +1 (binding)
> > > >
> > > > Thanks,
> > > > Haisheng Yuan
> > > >
> > >
> >
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Forward Xu]

Thanks, Haisheng!


Environment: Mac-OS Mojave (10.14.6)

JDK version: 1.8.0_211


Release notes: OK

Build with tests: OK

Checksums and signatures: OK


Vote:

+1 (non-binding)


Best,

Forward

XING JIN  于2020年5月19日周二 上午10:53写道：

> Thanks, Haisheng ~
>
> Local Calcite build with tests enabled on Linux: *OK*
> Calcite-based system test suite: *OK*
>
> Vote:
> +1 (non-binding)
>
> Francis Chuang  于2020年5月18日周一 下午2:00写道：
>
> > Thanks for making this release available for voting, Haisheng!
> >
> > Verified GPG signature - OK
> > Verified SHA512 - OK
> > Ran tests per HOWTO (./gradlew check) - OK
> > Quickly skimmed release notes - OK
> > Spotted checked a few JARs in the Maven repository - OK
> >
> > Environment (OpenJDK:latest docker container):
> > Gradle 6.3 (via gradlew)
> > Debian GNU/Linux 8
> > openjdk version "1.8.0_111"
> > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> >
> > My vote is: +1 (binding)
> >
> > Francis
> >
> > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.23.0, release
> > > candidate 1.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > >
> > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > (revision 39622)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > *apache-calcite-1.23.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://dist.apache.org/repos/dist/release/calcite/KEYS
> > >
> > > N.B.
> > > To create the jars and test Apache Calcite: "./gradlew build".
> > >
> > > If you do not have a Java environment available, you can run the tests
> > > using docker. To do so, install docker and docker-compose, then run
> > > "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite 1.23.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.23.0
> > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Thanks,
> > > Haisheng Yuan
> > >
> >
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[XING JIN]

Thanks, Haisheng ~

Local Calcite build with tests enabled on Linux: *OK*
Calcite-based system test suite: *OK*

Vote:
+1 (non-binding)

Francis Chuang  于2020年5月18日周一 下午2:00写道：

> Thanks for making this release available for voting, Haisheng!
>
> Verified GPG signature - OK
> Verified SHA512 - OK
> Ran tests per HOWTO (./gradlew check) - OK
> Quickly skimmed release notes - OK
> Spotted checked a few JARs in the Maven repository - OK
>
> Environment (OpenJDK:latest docker container):
> Gradle 6.3 (via gradlew)
> Debian GNU/Linux 8
> openjdk version "1.8.0_111"
> OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
>
> My vote is: +1 (binding)
>
> Francis
>
> On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.23.0, release
> > candidate 1.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> >
> > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> >
> > Tag:
> > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > (revision 39622)
> >
> > The hashes of the artifacts are as follows:
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > *apache-calcite-1.23.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://dist.apache.org/repos/dist/release/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.23.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.23.0
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Thanks,
> > Haisheng Yuan
> >
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Feng Zhu]

Thanks for work, Haisheng!

Environment: Windows-10/Mac-OS
JDK version: 1.8.0_241

Release notes: OK
Build with tests: OK
Checksums and signatures: OK

Vote: +1 (non-binding)

Haisheng Yuan  于2020年5月16日周六 下午12:02写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> (revision 39622)
>
> The hashes of the artifacts are as follows:
>
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> *apache-calcite-1.23.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/release/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.23.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.23.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Francis Chuang]

Thanks for making this release available for voting, Haisheng!

Verified GPG signature - OK
Verified SHA512 - OK
Ran tests per HOWTO (./gradlew check) - OK
Quickly skimmed release notes - OK
Spotted checked a few JARs in the Maven repository - OK

Environment (OpenJDK:latest docker container):
Gradle 6.3 (via gradlew)
Debian GNU/Linux 8
openjdk version "1.8.0_111"
OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)

My vote is: +1 (binding)

Francis

On 16/05/2020 2:02 pm, Haisheng Yuan wrote:

Hi all,

I have created a build for Apache Calcite 1.23.0, release
candidate 1.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3

Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3

Tag:
https://github.com/apache/calcite/tree/calcite-1.23.0-rc1

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
(revision 39622)

The hashes of the artifacts are as follows:
961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
*apache-calcite-1.23.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/

Release artifacts are signed with the following key:
https://dist.apache.org/repos/dist/release/calcite/KEYS

N.B.
To create the jars and test Apache Calcite: "./gradlew build".

If you do not have a Java environment available, you can run the tests
using docker. To do so, install docker and docker-compose, then run
"docker-compose run test" from the root of the directory.

Please vote on releasing this package as Apache Calcite 1.23.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.23.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Thanks,
Haisheng Yuan

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Stamatis Zampetakis]

Hello,

Thanks for driving this Haisheng!

I was checking the differences between RC0 and RC1:
https://github.com/apache/calcite/compare/calcite-1.23.0-rc0...calcite-1.23.0-rc1

and the change for CALCITE-3997 [1] seems a bit risky for this stage of the
release, thus I would like to invite more people to have a look.
If there are things to be discussed let's do it under the respective JIRA.

I will continue testing and vote later on.

Best,
Stamatis

[1]
https://github.com/apache/calcite/commit/7be30db36d449e0a7fcc76b7d4647e141f4bc72d


On Sun, May 17, 2020 at 1:45 PM Enrico Olivelli  wrote:

> +1 (non binding)
> Local tests passes on Linux (Fedora 31) + JDK14
> Checksums and signatures looks good.
>
> All tests are passing on HerdDB.
> Thank you very much Haisheng !
>
> Enrico
>
> Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai <
> anton.hai...@gmail.com> ha scritto:
>
> > Hello,
> >
> > Local Calcite build with tests enabled on Linux: *OK*
> > Calcite-based system (Zoomdata) test suite: *OK*
> >
> > Vote:
> > +1 (non-binding)
> >
> > On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan  wrote:
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.23.0, release
> > > candidate 1.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > >
> > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > (revision 39622)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > *apache-calcite-1.23.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://dist.apache.org/repos/dist/release/calcite/KEYS
> > >
> > > N.B.
> > > To create the jars and test Apache Calcite: "./gradlew build".
> > >
> > > If you do not have a Java environment available, you can run the tests
> > > using docker. To do so, install docker and docker-compose, then run
> > > "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite 1.23.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.23.0
> > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Thanks,
> > > Haisheng Yuan
> > >
> >
> >
> > --
> > Best regards,
> > Anton.
> >
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Enrico Olivelli]

+1 (non binding)
Local tests passes on Linux (Fedora 31) + JDK14
Checksums and signatures looks good.

All tests are passing on HerdDB.
Thank you very much Haisheng !

Enrico

Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai <
anton.hai...@gmail.com> ha scritto:

> Hello,
>
> Local Calcite build with tests enabled on Linux: *OK*
> Calcite-based system (Zoomdata) test suite: *OK*
>
> Vote:
> +1 (non-binding)
>
> On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan  wrote:
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.23.0, release
> > candidate 1.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> >
> > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> >
> > Tag:
> > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > (revision 39622)
> >
> > The hashes of the artifacts are as follows:
> >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > *apache-calcite-1.23.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://dist.apache.org/repos/dist/release/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.23.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.23.0
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Thanks,
> > Haisheng Yuan
> >
>
>
> --
> Best regards,
> Anton.
>

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Anton Haidai]

Hello,

Local Calcite build with tests enabled on Linux: *OK*
Calcite-based system (Zoomdata) test suite: *OK*

Vote:
+1 (non-binding)

On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan  wrote:

> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> (revision 39622)
>
> The hashes of the artifacts are as follows:
>
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> *apache-calcite-1.23.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/release/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.23.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.23.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>


-- 
Best regards,
Anton.

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Ruben Q L]

Hello everyone,

- Local Calcite build with tests (Windows10 + JDK8): OK
- Calcite-based application test suite: OK

However, the patch to correct the issue on RC0 [1] is a breaking change
(for some scenarios) that introduced a regression in my downstream project
that required a (temporary) quick-fix [2] (thanks Haisheng Yuan for your
help and reactivity). There is still some discussion going on in the Jira
ticket [1], and even though I am not 100% convinced on the direction that
was taken, I cannot provide a better alternative at this time (and in any
case with the quick-fix this is not a blocking issue on my side).
+0 (non binding)

Best regards,
Ruben

[1] https://issues.apache.org/jira/browse/CALCITE-3997
[2]
https://github.com/apache/calcite/commit/05376d6bff11ccef690addb4f9c40ab16dd20bec



Le sam. 16 mai 2020 à 06:02, Haisheng Yuan  a écrit :

> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
>
> Tag:
> https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> (revision 39622)
>
> The hashes of the artifacts are as follows:
>
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> *apache-calcite-1.23.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/release/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.23.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.23.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>

[VOTE] Release apache-calcite-1.23.0 (release candidate 1)

[Haisheng Yuan]

Hi all,

I have created a build for Apache Calcite 1.23.0, release
candidate 1.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3

Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3

Tag:
https://github.com/apache/calcite/tree/calcite-1.23.0-rc1

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
(revision 39622)

The hashes of the artifacts are as follows:
961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
*apache-calcite-1.23.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/

Release artifacts are signed with the following key:
https://dist.apache.org/repos/dist/release/calcite/KEYS

N.B.
To create the jars and test Apache Calcite: "./gradlew build".

If you do not have a Java environment available, you can run the tests
using docker. To do so, install docker and docker-compose, then run
"docker-compose run test" from the root of the directory.

Please vote on releasing this package as Apache Calcite 1.23.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.23.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Thanks,
Haisheng Yuan