[GitHub] spark issue #19095: [SPARK-21886][SQL] Use SparkSession.internalCreateDataFr...

2017-08-31 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/19095 That was really quick! Thanks a lot @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #19095: [SPARK-21886][SQL] Use SparkSession.internalCreat...

2017-08-31 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/19095 [SPARK-21886][SQL] Use SparkSession.internalCreateDataFrame to create… … Dataset with LogicalRDD logical operator ## What changes were proposed in this pull request

[GitHub] spark issue #19089: [SPARK-21728][core] Follow up: fix user config, auth in ...

2017-08-30 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/19089 Logs are back with the change. 👍 Thanks (and don't mess it up again fixing STS :)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-30 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135989439 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala --- @@ -130,16 +130,7 @@ class TextSocketSource(host

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135610992 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala --- @@ -126,16 +128,17 @@ class TextSocketSource(host

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135610632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala --- @@ -126,16 +128,17 @@ class TextSocketSource(host

[GitHub] spark pull request #19056: [SPARK-21765] Check that optimization doesn't aff...

2017-08-28 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/19056#discussion_r135610234 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -39,6 +39,16 @@ abstract class Optimizer

[GitHub] spark issue #18642: [MINOR][REFACTORING] KeyValueGroupedDataset.mapGroupsWit...

2017-07-20 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18642 @zsxwing @tdas Could you review the change and let me know what you think? I'd appreciate. Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18642: [MINOR][REFACTORING] KeyValueGroupedDataset.mapGroupsWit...

2017-07-17 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18642 @zsxwing @tdas Your friendly reminder to give the change a nice review. I'd appreciate. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #18642: [MINOR][REFACTORING] KeyValueGroupedDataset.mapGr...

2017-07-15 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/18642 [MINOR][REFACTORING] KeyValueGroupedDataset.mapGroupsWithState uses flatMapGroupsWithState ## What changes were proposed in this pull request? Refactored

[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation

2017-07-06 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18539 If you know how to display `ForeachWriter` that's passed in to `ForeachSink` nicely, let me know. `getClass.getName` didn't convince me and so I left it out. It'd be very helpful to see what

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

2017-07-06 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18509#discussion_r125874046 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala --- @@ -81,7 +81,7 @@ class

[GitHub] spark issue #18539: [SPARK-21313][SS] ConsoleSink's string representation

2017-07-05 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18539 I think that `ConsoleSink` was the only one with this mysterious name. We could however have another JIRA to _somehow_ unify how options are printed out for sources and sinks. I don't think

[GitHub] spark issue #18523: [SPARK-21285][ML] VectorAssembler reports the column nam...

2017-07-05 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18523 Thanks @facaiy for the changes. I wonder if the code could `collect` all the columns with incorrect type in one go (rather than reporting issues column by column until a user fixed all

[GitHub] spark pull request #18539: [SPARK-21313][SS] ConsoleSink's string representa...

2017-07-05 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/18539 [SPARK-21313][SS] ConsoleSink's string representation ## What changes were proposed in this pull request? Add `toString` with options for `ConsoleSink` so it shows nicely in query

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

2017-07-05 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18509#discussion_r125571708 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala --- @@ -81,7 +81,7 @@ class

[GitHub] spark pull request #18523: [SPARK-21285][ML] VectorAssembler reports the col...

2017-07-04 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18523#discussion_r125397518 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala --- @@ -113,12 +113,12 @@ class VectorAssembler @Since("

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

2017-07-03 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18509#discussion_r125353689 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala --- @@ -81,7 +81,7 @@ class

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

2017-07-03 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/18509 [SS][MINOR] Make EventTimeWatermarkExec explicitly UnaryExecNode ## What changes were proposed in this pull request? Making EventTimeWatermarkExec explicitly UnaryExecNode

[GitHub] spark pull request #18347: [SPARK-20599][SS] ConsoleSink should work with (b...

2017-06-18 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18347#discussion_r122617147 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -465,6 +465,8 @@ case class DataSource

[GitHub] spark pull request #18347: [SPARK-20599][SS] ConsoleSink should work with (b...

2017-06-18 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18347#discussion_r122616876 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -465,6 +465,8 @@ case class DataSource

[GitHub] spark issue #18144: [SPARK-20912][SQL] Allow column name in map functions.

2017-05-30 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18144 @cloud-fan If consistency is to remove (not add) I'm fine. Either way consistency is the ultimate goal (as I myself am running into this discrepancy far too often). --- If your project

[GitHub] spark pull request #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-30 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18074#discussion_r119168394 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala --- @@ -153,12 +153,13 @@ case class WindowExec

[GitHub] spark issue #18144: [SPARK-20912][SQL] Allow column name in map functions.

2017-05-30 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18144 @cloud-fan I don't understand why would that be an issue...ever. The API is not consistent and I often run into it. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-29 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/18074 Hey @srowen could you review the changes again and accept possibly? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-26 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18074#discussion_r118788857 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExec.scala --- @@ -153,19 +153,24 @@ case class WindowExec

[GitHub] spark issue #15575: [SPARK-18038] [SQL] Move output partitioning definition ...

2017-05-26 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/15575 I'm late with this, but just leaving it for future code reviewers... I think the change took the most extreme path where even such simple `outputPartitioning` as the one

[GitHub] spark pull request #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/18074#discussion_r118436041 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala --- @@ -35,12 +35,13 @@ import

[GitHub] spark pull request #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-23 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/18074 [DOCS][MINOR] Scaladoc fixes (aka typo hunting) ## What changes were proposed in this pull request? Minor changes to scaladoc ## How was this patch tested? Local

[GitHub] spark pull request #18026: [SPARK-16202][SQL][DOC] Follow-up to Correct The ...

2017-05-18 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/18026 [SPARK-16202][SQL][DOC] Follow-up to Correct The Description of CreatableRelationProvider's createRelation ## What changes were proposed in this pull request? Follow-up to SPARK

[GitHub] spark issue #17917: [SPARK-20600][SS] KafkaRelation should be pretty printed...

2017-05-11 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17917 https://cloud.githubusercontent.com/assets/62313/25960541/879096ce-3677-11e7-900f-09bd5f200a00.png;> --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark issue #16960: [SPARK-19447] Make Range operator generate "recordsRead"...

2017-05-11 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16960 I'll have a look at this this week and send a PR unless you beat me to it :) Thanks @ala! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #17917: [SPARK-20600][SS] KafkaRelation should be pretty ...

2017-05-10 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17917#discussion_r115711771 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaRelation.scala --- @@ -143,4 +143,6 @@ private[kafka010] class

[GitHub] spark issue #16960: [SPARK-19447] Make Range operator generate "recordsRead"...

2017-05-10 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16960 I think that the commit has left [numGeneratedRows](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala#L344

[GitHub] spark issue #17904: [SPARK-20630] [Web UI] Fixed column visibility in Execut...

2017-05-09 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17904 WFM. Thanks @ajbozarth! ``` $ git fetch origin pull/17904/head:17904 $ gco 17904 $ ./build/mvn -Phadoop-2.7,yarn,mesos,hive,hive-thriftserver -DskipTests clean install

[GitHub] spark pull request #17917: [SPARK-20600][SS] KafkaRelation should be pretty ...

2017-05-09 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17917 [SPARK-20600][SS] KafkaRelation should be pretty printed in web UI ## What changes were proposed in this pull request? User-friendly name of `KafkaRelation` in web UI (under Details

[GitHub] spark pull request #17727: [SQL][MINOR] Remove misleading comment (and tags ...

2017-05-06 Thread jaceklaskowski
Github user jaceklaskowski closed the pull request at: https://github.com/apache/spark/pull/17727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (an...

2017-04-28 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17801 Are the errors (that led to `fails to generate documentation`) after my change? Look very weird to me. ``` [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target

[GitHub] spark pull request #17801: [MINOR][SQL][DOCS] Improve unix_timestamp's scala...

2017-04-28 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17801 [MINOR][SQL][DOCS] Improve unix_timestamp's scaladoc (and typo hunting) ## What changes were proposed in this pull request? * Docs are consistent (across different `unix_timestamp

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-26 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17727 Is the comment correct then? I don't think so. What about improving it? I don't mind if we stop discussing it either. It's a tiny change after all (and don't want to drag it along and waste

[GitHub] spark issue #17727: [SQL][MINOR] Remove misleading comment (and tags do bett...

2017-04-22 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17727 Fair enough. Let's do it here. Quoting directly from the code: > Converts a logical plan into zero or more SparkPlans. This API is exposed for experimenting with the query plan

[GitHub] spark pull request #17727: [SQL][MINOR] Remove misleading comment (and tags ...

2017-04-22 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17727 [SQL][MINOR] Remove misleading comment (and tags do better) ## What changes were proposed in this pull request? Misleading comment removed (and tags do a better job to express

[GitHub] spark pull request #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17712#discussion_r112692885 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -47,20 +47,31 @@ case class UserDefinedFunction

[GitHub] spark pull request #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17712#discussion_r112692504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -47,20 +47,31 @@ case class UserDefinedFunction

[GitHub] spark pull request #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17712#discussion_r112634952 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala --- @@ -256,10 +256,12 @@ class UDFSuite extends QueryTest

[GitHub] spark pull request #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17712#discussion_r112634044 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -47,12 +47,20 @@ case class UserDefinedFunction

[GitHub] spark pull request #17712: [SPARK-20416][SQL] Print UDF names in EXPLAIN

2017-04-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17712#discussion_r112634273 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala --- @@ -256,10 +256,12 @@ class UDFSuite extends QueryTest

[GitHub] spark issue #17670: [SPARK-20281][SQL] Print the identical Range parameters ...

2017-04-18 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17670 I think the change should rather be [here](ResolveTableValuedFunctions) where the built-in table-valued function `range` is resolved. --- If your project is set up for it, you can reply

[GitHub] spark pull request #17657: [TEST][MINOR] Replace repartitionBy with distribu...

2017-04-17 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17657 [TEST][MINOR] Replace repartitionBy with distribute in CollapseRepartitionSuite ## What changes were proposed in this pull request? Replace non-existent `repartitionBy

[GitHub] spark pull request #17417: [DOCS] Docs-only improvements

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r10842 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -60,7 +60,7 @@ import org.apache.spark.util.Utils

[GitHub] spark pull request #17417: [DOCS] Docs-only improvements

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108777513 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -26,7 +26,8 @@ import

[GitHub] spark pull request #17417: [DOCS] Docs-only improvements

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108777037 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -75,7 +75,6 @@ case class

[GitHub] spark pull request #17417: [DOCS] Docs-only improvements

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108776915 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java --- @@ -52,16 +52,15 @@ * This class implements

[GitHub] spark issue #17417: [DOCS] Docs-only improvements

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17417 Executed `cd docs && SKIP_PYTHONDOC=1 SKIP_RDOC=1 jekyll serve` to check the changes and they've seemed fine. I had to fix some extra javadoc-related places to pleas

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108665073 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -492,7 +492,7 @@ class AstBuilder extends

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski closed the pull request at: https://github.com/apache/spark/pull/17434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17434 Closing as it was merged into https://github.com/apache/spark/pull/17417. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108634808 --- Diff: core/src/main/java/org/apache/spark/memory/MemoryConsumer.java --- @@ -60,8 +60,6 @@ protected long getUsed

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108633245 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -323,7 +323,7 @@ class SparkSession private( * // |-- age

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108632961 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -492,7 +492,7 @@ class AstBuilder extends

[GitHub] spark pull request #17434: [MINOR] Typo fixes

2017-03-29 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17434#discussion_r108632590 --- Diff: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala --- @@ -82,13 +82,13 @@ private[spark] class SortShuffleManager

[GitHub] spark issue #17417: [SQL][DOC] Use recommended values for row boundaries in ...

2017-03-28 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17417 I'm going to merge the two PRs with your comments applied (i.e. excluding changes that are not necessarily doc-only). Thanks a lot for your time, Sean. Appreciate a lot. --- If your

[GitHub] spark issue #17434: [MINOR] Typo fixes

2017-03-27 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17434 You'd asked I delivered @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17417: [SQL][DOC] Use recommended values for row boundaries in ...

2017-03-27 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17417 Hey @srowen Would appreciate your looking at the changes again and comments (or merge). Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #17434: [SQL][DOC][MINOR] Squashing a typo in from_json f...

2017-03-26 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17434 [SQL][DOC][MINOR] Squashing a typo in from_json function ## What changes were proposed in this pull request? Just squashing a typo in `from_json` function ## How

[GitHub] spark pull request #17417: [SQL][DOC] Use recommended values for row boundar...

2017-03-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108035549 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala --- @@ -113,12 +113,12 @@ object Window { * Creates

[GitHub] spark pull request #17417: [SQL][DOC] Use recommended values for row boundar...

2017-03-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108035498 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala --- @@ -131,9 +131,9 @@ object Window { * import

[GitHub] spark pull request #17417: [SQL][DOC] Use recommended values for row boundar...

2017-03-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108035475 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala --- @@ -113,12 +113,12 @@ object Window { * Creates

[GitHub] spark pull request #17417: [SQL][DOC] Use recommended values for row boundar...

2017-03-25 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/17417#discussion_r108035464 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala --- @@ -22,7 +22,7 @@ import org.apache.spark.sql.Column import

[GitHub] spark pull request #17417: [SQL][DOC] Use recommended values for row boundar...

2017-03-24 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17417 [SQL][DOC] Use recommended values for row boundaries in Window's scal… …adoc ## What changes were proposed in this pull request? Use recommended values for row

[GitHub] spark pull request #17409: [SQL][MINOR] Fix for typo in Analyzer

2017-03-24 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17409 [SQL][MINOR] Fix for typo in Analyzer ## What changes were proposed in this pull request? Fix for typo in Analyzer ## How was this patch tested? local build You

[GitHub] spark pull request #17337: [SQL][MINOR] Fix scaladoc for UDFRegistration

2017-03-17 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17337 [SQL][MINOR] Fix scaladoc for UDFRegistration ## What changes were proposed in this pull request? Fix scaladoc for UDFRegistration ## How was this patch tested

[GitHub] spark pull request #16061: [SPARK-18278] [Scheduler] Support native submissi...

2017-03-03 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16061#discussion_r104206250 --- Diff: kubernetes/pom.xml --- @@ -0,0 +1,54 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] spark pull request #16061: [SPARK-18278] [Scheduler] Support native submissi...

2017-03-03 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16061#discussion_r104206163 --- Diff: kubernetes/pom.xml --- @@ -0,0 +1,54 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] spark pull request #16061: [SPARK-18278] [Scheduler] Support native submissi...

2017-03-03 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16061#discussion_r104205883 --- Diff: kubernetes/README.md --- @@ -0,0 +1,21 @@ +# Pre-requisites +* maven, JDK and all other pre-requisites for building Spark

[GitHub] spark pull request #17042: [CORE][MINOR] Fix scaladoc

2017-02-24 Thread jaceklaskowski
Github user jaceklaskowski closed the pull request at: https://github.com/apache/spark/pull/17042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #17042: [CORE][MINOR] Fix scaladoc

2017-02-24 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/17042 Makes sense. Thanks @srowen! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17042: [CORE][MINOR] Fix scaladoc

2017-02-23 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/17042 [CORE][MINOR] Fix scaladoc ## What changes were proposed in this pull request? Minor change to scaladoc of `HeartbeatReceiver` (the method is certainly not for tests only

[GitHub] spark pull request #16812: [SPARK-19465][SQL] Added options for custom boole...

2017-02-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16812#discussion_r99935530 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -139,6 +140,20 @@ class CSVSuite extends

[GitHub] spark pull request #16812: [SPARK-19465][SQL] Added options for custom boole...

2017-02-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16812#discussion_r99935349 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchemaSuite.scala --- @@ -73,6 +73,12 @@ class

[GitHub] spark pull request #16812: [SPARK-19465][SQL] Added options for custom boole...

2017-02-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16812#discussion_r99934599 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -110,7 +110,11 @@ private[csv] class

[GitHub] spark pull request #16550: [SPARK-19178][SQL] convert string of large number...

2017-01-12 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16550#discussion_r95871812 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -835,6 +835,187 @@ public UTF8String translate(Map

[GitHub] spark pull request #16481: [SPARK-19092] [SQL] Save() API of DataFrameWriter...

2017-01-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16481#discussion_r95065596 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -494,8 +500,13 @@ case class DataSource

[GitHub] spark pull request #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHand...

2017-01-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16492#discussion_r95065464 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -235,7 +235,10 @@ trait StreamTest extends QueryTest

[GitHub] spark pull request #16492: [SPARK-19113][SS][Tests]Set UncaughtExceptionHand...

2017-01-07 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/16492#discussion_r95065415 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -238,7 +238,7 @@ class StreamSuite extends StreamTest

[GitHub] spark issue #16475: [MINOR][CORE] Remove code duplication (so the interface ...

2017-01-06 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16475 Closed as per @rxin's request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16475: [MINOR][CORE] Remove code duplication (so the int...

2017-01-06 Thread jaceklaskowski
Github user jaceklaskowski closed the pull request at: https://github.com/apache/spark/pull/16475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark issue #16475: [MINOR][CORE] Remove code duplication (so the interface ...

2017-01-05 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16475 Partially agree @srowen. The reason for the change was `blockId.isShuffle` condition that both methods use to do their shuffle-specific handling. The change might not be the most correct one

[GitHub] spark issue #16475: [MINOR][CORE] Remove code duplication (so the interface ...

2017-01-05 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16475 Proposed the changes since it made easier to understand the role of `getBlockData` vs `getLocalBytes` and in the end `ShuffleBlockResolver`. I'm not saying it should be accepted, but I'd

[GitHub] spark pull request #16475: [MINOR][CORE] Remove code duplication (so the int...

2017-01-05 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/16475 [MINOR][CORE] Remove code duplication (so the interface is used instead) ## What changes were proposed in this pull request? Removed code duplication and used the interface instead

[GitHub] spark issue #16309: [WIP][SPARK-18896][TESTS] Update to ScalaTest 3.0.1

2016-12-25 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 For reference: [scala-xml releases](https://github.com/scala/scala-xml/releases) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-18 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 The reason for the update to `scala-xml_2.11-1.0.5.jar` was that once I updated ScalaTest I got the issue from Jenkins that the dependency list changed. That's when I was told about `./dev

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-17 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 The tests ran locally on my laptop have finished after...`7431 s` which is 2 hours (!) ``` [error] (sql/test:test) sbt.TestsFailedException: Tests unsuccessful [error

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-17 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 @srowen Please help as I'm stuck with the `OutOfMemoryError: GC overhead limit exceeded` error. Should Jenkins run the tests with 6g? What's even more interesting is that the tests

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-17 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 Rebasing with master to trigger tests on Jenkins...(hoping this time they pass) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-16 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 I'm testing the changes locally with the following: ``` export SCALACTIC_FILL_FILE_PATHNAMES=yes export SBT_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m" sb

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-16 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 Hey @srowen, any idea about the following error? I'd appreciate any hints to help me fix it. ``` [info] - can use a custom recovery mode factory (57 milliseconds) Exception

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-16 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 Think the latest test failures are somehow related to: ``` Please set the environment variable SCALACTIC_FILL_FILE_PATHNAMES to yes at compile time to enable this feature

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-16 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 Learnt about `./dev/test-dependencies.sh --replace-manifest` just now. (Where's this all described?) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16309: [SPARK-18896][TESTS] Suppress ScalaCheck warning

2016-12-16 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/16309 Just learnt about `export SPARK_TESTING=1` to avoid some test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

<    1   2   3   4   5   6   >