Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

FYI, the enterprise policy landed in M124 (under "PrefixedVideoFullscreenApiAvailability"), and the deprecation trial will activate when M125 branches, on April 15th. On Fri, Feb 2, 2024 at 12:16 PM Mike Taylor wrote: > LGTM3 > On 2/2/24 1:03 AM, Domenic Denicola wrote: > > LGTM2. Please be

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

LGTM3 On 2/2/24 1:03 AM, Domenic Denicola wrote: LGTM2. Please be sure to update Chrome Status with the deprecation trial timelines and removal milestones so that data gets fed into the feature dashboard, beta blog posts, etc. On Fri, Feb 2, 2024 at 7:35 AM Thomas Guilbert wrote:

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

LGTM2. Please be sure to update Chrome Status with the deprecation trial timelines and removal milestones so that data gets fed into the feature dashboard, beta blog posts, etc. On Fri, Feb 2, 2024 at 7:35 AM Thomas Guilbert wrote: > Thank you! > > I will be adding an enterprise policy to

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thank you! I will be adding an enterprise policy to re-enable the APIs if necessary, as part of the enterprise review. Deprecating the enterprise policy will become the new objective after the proper amount of time has elapsed, before the code can be deleted for good. I will keep updating this

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thank you Thomas! As far as I'm aware that's all of the paperwork completed, so LGTM1 to disable the APIs by default and at the same time start a reverse origin trial to re-enable them for 6 months. If you hear feedback requesting an extension towards the end of those 6 months, please request an

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thanks for marking it for review! I submitted a request to review this change to the chromium enterprise mailing list. Thanks, Thomas On Wed, Jan 31, 2024 at 1:08 PM Mike Taylor wrote: > Yep - seems that's the cause of confusion. In your first email, >

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Yep - seems that's the cause of confusion. In your first email, https://chromestatus.com/feature/5259513871466496 is linked from the bottom, so our review tooling is presenting that to us. But I've just flagged the new one so it will show up as well. thanks! On 1/31/24 2:41 PM, Thomas

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

I requested privacy/security/debuggability on the video element fullscreen API deprecation feature last week. Privacy and debuggability are approved, just waiting on security. Mike, are you talking about requesting those

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Apologies in advance for excessive paperwork, but can you also put https://chromestatus.com/feature/5111638103687168 through the process, requesting enterprise signoff in particular? Enterprise folks could depend on this and might need to take some extra action, and a "Feature deprecation" entry

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Gentle reminder to follow up on requesting privacy/security/debuggability approvals in chromestatus (which is currently blocking LGTMs). On Wednesday, January 24, 2024 at 7:23:28 AM UTC-5 Mike Taylor wrote: > Would you mind requesting reviews for the various gates (privacy, > security,

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thanks Thomas, looking forward to being able to say LGTM to this :) I agree that it would be ideal if the unprefixed API is supported on iOS before we remove the video-specific prefixed APIs in Chrome, so that people can have confidence their updated code will work in both Chrome and Safari. On

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Ok for a 6 months trial, with the possibility to extend it further. I will wait for the remaining security/privacy approvals and then update this thread again. Additionally, someone commented on the WebKit positions standards thread

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

https://sites.google.com/a/chromium.org/dev/blink/launching-features doesn't give any guidance on the timeline, so let's just pick a timeline that makes sense for this case. It's been up to a year in other cases. Since feature detection is common, we have to remove the whole API surface and let

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thank you Wesley for the useful information! > What timeline do you have in mind? I'm not sure what reasonable timelines are, not having dealt with deprecations before. Is 3 months for a deprecation trial acceptable? Devtools should already have deprecation warnings

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

I'm also happy to support a plan to deprecate and remove. The use counter that best represents worst-case user impact at https://chromestatus.com/metrics/feature/timeline/popularity/170 at ~0.001%. But that's only when fullscreen actually happens (on user interaction) and it's very hard to say

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

On Thu, Jan 25, 2024 at 2:00 AM Wesley Luyten wrote: > Wesley from Mux here. I saw the issue come by. > > We'd be happy those API's could get deprecated and unified into the new > one. > > Our Media Chrome (library, not browser) implementation handles this > gracefully, some code here > >

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

On Tue, Jan 23, 2024 at 2:31 AM Domenic Denicola wrote: > > > On Tue, Jan 23, 2024 at 7:55 AM Thomas Guilbert > wrote: > >> Good point about the most used APIs being the boolean properties! The >> APIs are now only aliases for the standard non-prefixed fullscreen APIs (see >> this code for the

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Thanks Thomas for all your work here! Your HTTP Archive survey seems promising to me: it sounds like there are no regressions, and you found some great places to perform outreach. (Hi Wesley!) I'm happy to LGTM this as soon as the privacy/security reviews are approved and you've picked a target

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Wesley from Mux here. I saw the issue come by. We'd be happy those API's could get deprecated and unified into the new one. Our Media Chrome (library, not browser) implementation handles this gracefully, some code here

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

I opened a support ticket with Mux, and opened an issue for Clappr . On Wed, Jan 24, 2024 at 3:40 PM Thomas Guilbert wrote: > I've created a new ChromeStatus entry > , and requested the >

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

I've created a new ChromeStatus entry , and requested the privacy/security/debuggability gates for the deprecation trial. I audited a little more than 20 sites from the HTTP Archive. I've found a few JS player libraries that primarily use the

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Would you mind requesting reviews for the various gates (privacy, security, debuggability) for an OT/DT in your chromestatus entry? On 1/19/24 10:43 PM, Thomas Guilbert wrote: Contact emails tguilb...@chromium.org Explainer None Specification

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

On Tue, Jan 23, 2024 at 7:55 AM Thomas Guilbert wrote: > Good point about the most used APIs being the boolean properties! The APIs > are now only aliases for the standard non-prefixed fullscreen APIs (see > this code for the current implementation >

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Good point about the most used APIs being the boolean properties! The APIs are now only aliases for the standard non-prefixed fullscreen APIs (see this code for the current implementation

Re: [blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

It would be very exciting to clean this up! I have some questions that might help clarify the cost-benefit analysis. On Sat, Jan 20, 2024 at 6:43 AM Thomas Guilbert wrote: > Contact emails > > tguilb...@chromium.org > > Explainer > > None > > Specification > >

[blink-dev] Request for Deprecation Trial : HTMLVideoElement-specific Prefixed Fullscreen API

Contact emails tguilb...@chromium.org Explainer None Specification https://fullscreen.spec.whatwg.org/#dom-document-fullscreenenabled Summary There was an attempt in 2014 to deprecate and remove the