Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Haisheng, Thanks for the release announcement yesterday: https://lists.apache.org/thread.html/r555d7f90568ef199c65dfddcf58b14076ac803c0dca64d945d75ba69%40%3Cannounce.apache.org%3E. Can you also send it to dev@? Thank you for getting those 6 PRs into master (3985, 3988, 3910, 3999, 3478, 3950).

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Now it is back to normal: https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.23.0/ On 2020/05/26 14:00:50, Haisheng Yuan wrote: > Hi Enrico, > > Thanks for reporting the issue. > > I have created a JIRA ticket: > https://issues.apache.org/jira/browse/INFRA-20326 > > Thanks, >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hi Enrico, Thanks for reporting the issue. I have created a JIRA ticket: https://issues.apache.org/jira/browse/INFRA-20326 Thanks, Haisheng On 2020/05/26 09:20:14, Enrico Olivelli wrote: > Vladimir o Haisheng > could you please open a ticket to INFRA ? > I can do it myself, with your

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Vladimir o Haisheng could you please open a ticket to INFRA ? I can do it myself, with your permission (I am not in Calcite PMC/committers group) Otherwise it is not possible to use Calcite 1.23.0 from downstream projects Enrico Il giorno mar 26 mag 2020 alle ore 10:34 Vladimir Sitnikov <

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

ASF releases are shared with repository.apache.org: https://repository.apache.org/service/local/repositories/releases/content/org/apache/calcite/calcite-core/1.23.0/calcite-core-1.23.0.pom It might be there are issues with ASF Nexus and Sonatype Nexus sync. Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Haisheng I still can't see Calcite 1.23.0 on Maven Central https://search.maven.org/search?q=a:calcite-core did the release procedure complete successfully? Enrico Il giorno dom 24 mag 2020 alle ore 14:35 JiaTao Tao ha scritto: > Vote: +1 (non-binding) > > CALCITE-3819

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Vote: +1 (non-binding) CALCITE-3819 really helps infinite planning in our use case. And I'm looking forward to CALCITE-3997. --- Environment: Mac-OS JDK version: 1.8.0_212 Build with tests: OK Regards! Aron Tao Vladimir Sitnikov

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

>Looks like it is expected: >https://github.com/gradle/gradle/issues/9758 It is not expected. The way to fix it is to apply the following patch: --- a/buildSrc/build.gradle.kts +++ b/buildSrc/build.gradle.kts @@ -19,7 +19,6 @@ import com.github.vlsi.gradle.properties.dsl.props import

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

> * the first line printed by gradle is ':jar: No valid plugin > descriptors were found in META-INF/gradle-plugins'; I don't know > whether this is bad, but it looks bad Looks like it is expected: https://github.com/gradle/gradle/issues/9758 On 2020/05/21 18:41:41, Julian Hyde wrote: > -1

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hi Vladimir, Thanks for your explanation. And thanks a lot for providing such an amazing release tool for us! Cheers, Haisheng On 2020/05/23 16:28:52, Vladimir Sitnikov wrote: > >But it said build successful. Is there anything I can do for the 404 Not > Found error? > > It means "staging

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

>But it said build successful. Is there anything I can do for the 404 Not Found error? It means "staging repository no longer exists as it has just been released". I've raised https://github.com/gradle-nexus/publish-plugin/issues/29 to heal that. However, gradle-nexus/publish-plugin is not yet

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hi, I had the following error when executing the command: ./gradlew publishDist -Prc=1 -Pasf > Task :releaseRepository Initialized stagingRepositoryId orgapachecalcite-1089 for repository nexus <==---> 50% EXECUTING [1m 17s] GET request failed. 404: Not Found, body: [errors:[[id:*,

[RESULT] [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 5 binding +1s: Haisheng, Francis, Danny, Julian Hyde, Laurent 5 non-binding +1s: Anton, Enrico, Feng Zhu, Xing Jin, Forward Xu 1 non-binding +0s: Ruben Q L Therefore I am

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

My intent was not to cause sadness, sorry about that. I should have elaborated a bit more why I don't think Github is that much of an issue: - LICENSE file at the root of the project is the source of truth, not Github mention. It is a nice to have the correct license for Github for sure, but it

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Laurent>As for Github, I think this is a non-issue I have provided an example: https://github.com/embox/embox It is an example when GitHub fails to detect the license. It is really sad to hear that "you think it is a non-issue" even in case you have seen the failure case. Laurent>on the source

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Vote: +1 (binding) - Local Calcite builds (./gradlew clean build && ./gradlew testSlow) on MacOS and JDK8/11/14: OK - tarball content and signature: OK On Fri, May 15, 2020 at 9:02 PM Haisheng Yuan wrote: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

I meant the source distribution here. I guess I didn't realize Calcite source tree has embedded copies of some 3rd party css/js, but since those are not fetched dynamically and are part of the source tree, I think the committed LICENCE file should include those vs altering it at release time. As

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

My keys are signed by Stamatis, thanks for helping, Stamatis! Now the keys link worked, https://people.apache.org/keys/committer/hyuan.asc No more action is needed, Julian. Thanks, Haisheng On 2020/05/22 00:25:15, Julian Hyde wrote: > OK, I imported Haisheng's key from KEYS and now it

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE Laurent> bundled with the distribution? Which distribution do you mean? Of course, Calcite source release bundles third-party dependencies (e.g. site/js/*.js files). Vladimir

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE bundled with the distribution? On Fri, May 22, 2020 at 12:45 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Julian>It does not need to happen before > Julian>the release, but before we announce. > >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Julian>It does not need to happen before Julian>the release, but before we announce. Cross-signing is not required at all. Julian>All files should match those in the source repo at that Julian>precise commit. Julian> Could this version of LICENSE be the committed one? Long story short: LICENSE

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks. To Julian and Stamatis, Can you help sign my keys? 3CD22ABAC50DDCEF 41CAB58D1DA97F7D We can hangout if it is required. Thanks, Haisheng On 2020/05/22 00:25:15, Julian Hyde wrote: > OK, I imported Haisheng's key from KEYS and now it checks out. The > message "no public key" was

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

OK, I imported Haisheng's key from KEYS and now it checks out. The message "no public key" was confusing - I thought it meant that the file was not signed, whereas gpg meant that it did not recognize the key. Changing my vote to +1. Haisheng, can you please get one or two people to sign your

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

>-1 because of signature issues noted in previous email (hoping I'm mistaken). I think you are confused because Haisheng uses multiple keys. https://people.apache.org/keys/committer/ lists two keys, and https://dist.apache.org/repos/dist/release/calcite/KEYS does include the key that signs the

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

-1 because of signature issues noted in previous email (hoping I'm mistaken). Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT, compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14), compared contents of source distro with contents of git. * howto.md doesn't mention JDK

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Maybe I'm mistaken, but the source tarball doesn't seem to be signed: $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc apache-calcite-1.23.0-src.tar.gz gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT gpg:using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF gpg: Can't

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

I built the site both from the repo (git tag) and apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot checked. From what I could tell, there wasn't an obvious difference (random clicks were limited though). My personal opinion is that the 1.23.0 rc1 can continue. If someone knows

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Indeed there is an extra site/fonts in the git tag. I didn't see it in the last two releases (the diff on licenses are normal). So the question is, does it matter for the diff on site/? At least the artifact has the same source code as the tag (thus can build the same jar, behave the same when

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper * Checked signatures and checksums OK * Build (./gradlew clean assemble) on git repo and source artifacts OK * Run unit tests (./gradlew clean test) on git repo and source artifacts OK * Run slow tests (./gradlew clean

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks Haisheng for driving this! Verified GPG signature - OK Verified SHA512 - OK Release notes - OK Diff the files in the release artifact and tag - ok As for Calcite 3997, it only affects the Physical node, I’m fine with that ~ So +1 (binding) ~ Gradle 6.3 (via gradlew) Mac OS High Sierra

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks, Haisheng! Environment: Mac-OS Mojave (10.14.6) JDK version: 1.8.0_211 Release notes: OK Build with tests: OK Checksums and signatures: OK Vote: +1 (non-binding) Best, Forward XING JIN 于2020年5月19日周二 上午10:53写道： > Thanks, Haisheng ~ > > Local Calcite build with tests enabled

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks, Haisheng ~ Local Calcite build with tests enabled on Linux: *OK* Calcite-based system test suite: *OK* Vote: +1 (non-binding) Francis Chuang 于2020年5月18日周一 下午2:00写道： > Thanks for making this release available for voting, Haisheng! > > Verified GPG signature - OK > Verified SHA512 - OK

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks for work, Haisheng! Environment: Windows-10/Mac-OS JDK version: 1.8.0_241 Release notes: OK Build with tests: OK Checksums and signatures: OK Vote: +1 (non-binding) Haisheng Yuan 于2020年5月16日周六 下午12:02写道： > Hi all, > > I have created a build for Apache Calcite 1.23.0, release >

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Thanks for making this release available for voting, Haisheng! Verified GPG signature - OK Verified SHA512 - OK Ran tests per HOWTO (./gradlew check) - OK Quickly skimmed release notes - OK Spotted checked a few JARs in the Maven repository - OK Environment (OpenJDK:latest docker container):

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hello, Thanks for driving this Haisheng! I was checking the differences between RC0 and RC1: https://github.com/apache/calcite/compare/calcite-1.23.0-rc0...calcite-1.23.0-rc1 and the change for CALCITE-3997 [1] seems a bit risky for this stage of the release, thus I would like to invite more

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

+1 (non binding) Local tests passes on Linux (Fedora 31) + JDK14 Checksums and signatures looks good. All tests are passing on HerdDB. Thank you very much Haisheng ! Enrico Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai < anton.hai...@gmail.com> ha scritto: > Hello, > > Local Calcite

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hello, Local Calcite build with tests enabled on Linux: *OK* Calcite-based system (Zoomdata) test suite: *OK* Vote: +1 (non-binding) On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan wrote: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release > candidate 1. > > Thanks to

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hello everyone, - Local Calcite build with tests (Windows10 + JDK8): OK - Calcite-based application test suite: OK However, the patch to correct the issue on RC0 [1] is a breaking change (for some scenarios) that introduced a regression in my downstream project that required a (temporary)

[VOTE] Release apache-calcite-1.23.0 (release candidate 1)

Hi all, I have created a build for Apache Calcite 1.23.0, release candidate 1. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md The commit to be voted upon: