OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576354443
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
OmniaGM commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2072445566
We also have couple of out-of-date parameters in javaDocs, we can either fix
here or have another followup pr
-
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576366593
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840125#comment-17840125
]
Igor Soarez commented on KAFKA-16606:
-
Thanks for bringing this to my attention [~mimaison].
Hi
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840132#comment-17840132
]
Jakub Scholz commented on KAFKA-16606:
--
[~soarez] That sounds like without using the 3.7-IV2
johnnychhsu commented on PR #15720:
URL: https://github.com/apache/kafka/pull/15720#issuecomment-2072812226
thanks for the review @cmccabe !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576531833
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -84,17 +125,38 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends
lianetm commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072864210
@chia7712 's comment makes sense to me, and heads-up, similar classes are
already defined in
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576351984
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840118#comment-17840118
]
Mickael Maison commented on KAFKA-16606:
cc [~soarez]
> JBOD support in KRaft does not seem to
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576386813
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
johnnychhsu opened a new pull request, #15788:
URL: https://github.com/apache/kafka/pull/15788
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
frankvicky commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072734321
Hi @lianetm, @chia7712
Thanks for the suggestions, I have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840148#comment-17840148
]
Igor Soarez commented on KAFKA-16606:
-
That's right [~scholzj] . When KIP-858 started, the
chia7712 commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2072851173
@johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840150#comment-17840150
]
Mickael Maison commented on KAFKA-16606:
To me that kind of looks like a bug. Previously JBOD
José Armando García Sancio created KAFKA-16607:
--
Summary: Update the KIP and metrics implementation to include the
new state
Key: KAFKA-16607
URL: https://issues.apache.org/jira/browse/KAFKA-16607
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576358398
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -300,7 +300,7 @@ class ReplicaManager(val config: KafkaConfig,
protected val allPartitions = new
KevinZTW commented on code in PR #15714:
URL: https://github.com/apache/kafka/pull/15714#discussion_r1576372796
##
storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576375031
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576422765
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -959,7 +960,7 @@ class ZkAdminManager(val config: KafkaConfig,
} else if
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576432135
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576432963
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -121,16 +146,16 @@ public BrokerNode build(
private final boolean combined;
private final Map
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576492165
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,17 +69,30 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
johnnychhsu commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1576500340
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1576507146
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072841232
@frankvicky @m1a2st It seems your PR (#15766 and #15779) need a consumer
running in background. Hence, we can consider moving
`AbstractConsumerGroupExecutor`/`ConsumerGroupExecutor` to
lucasbru opened a new pull request, #15789:
URL: https://github.com/apache/kafka/pull/15789
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
frankvicky commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072873129
> @frankvicky @m1a2st It seems your PR (#15766 and #15779) need a consumer
running in background. Hence, we can consider moving
`AbstractConsumerGroupExecutor`/`ConsumerGroupExecutor`
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576385492
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576375031
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576420731
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -144,7 +144,7 @@ case class LogReadResult(info: FetchDataInfo,
def withEmptyFetchInfo:
mfvitale commented on PR #15756:
URL: https://github.com/apache/kafka/pull/15756#issuecomment-2072820368
> The `configure()` method on Transformation is only called with
configurations provided with their prefix.
This cleared my doubt. So in that case it should be clear declared as
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576360092
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -52,8 +51,8 @@ object ZooKeeperClient {
* @param sessionTimeoutMs session timeout in milliseconds
nikramakrishnan commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2072530250
Bump! @satishd @kamalcph can we get this review going? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576409478
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
mimaison commented on PR #15756:
URL: https://github.com/apache/kafka/pull/15756#issuecomment-2072692296
While it's not directly adding new configurations, it's effectively changing
the behavior of `ExtractField` and `InsertField` and making them support new
configurations. The
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-16604:
-
Assignee: Sagar Rao
> Deprecate ConfigDef.ConfigKey constructor from public APIs
>
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840163#comment-17840163
]
Sagar Rao commented on KAFKA-16604:
---
[~chia7712] , ok i have assigned it to myself.
> Deprecate
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576631689
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -59,87 +63,66 @@ public Builder setCombined(boolean combined) {
}
public Builder
Jakub Scholz created KAFKA-16606:
Summary: JBOD support in KRaft does not seem to be gated by the
metadata version
Key: KAFKA-16606
URL: https://issues.apache.org/jira/browse/KAFKA-16606
Project:
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576363327
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576385492
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576392526
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576457731
##
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakub Scholz resolved KAFKA-16606.
--
Resolution: Not A Problem
> JBOD support in KRaft does not seem to be gated by the metadata
johnnychhsu commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2072775161
nice fix! crystal clear solution :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576508031
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1576516058
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576523223
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,440 @@
package org.apache.kafka.tools.consumer.group;
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575753935
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575754146
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
[
https://issues.apache.org/jira/browse/KAFKA-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839981#comment-17839981
]
Daniel Urban commented on KAFKA-13459:
--
[~viktorsomogyi] No plans, and it does require a KIP.
>
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576735920
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16608:
--
Component/s: consumer
> AsyncKafkaConsumer doesn't honour interrupted thread status on
>
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576836597
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
}
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16584:
Labels: needs-kip newbie (was: )
> Make log processing summary configurable or debug
>
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840191#comment-17840191
]
Kirk True commented on KAFKA-16217:
---
[~calvinliu]—I noticed the PR request 15541 is merged, but the
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576751637
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
riedelmax commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1576821065
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Andrew Schofield created KAFKA-16608:
Summary: AsyncKafkaConsumer doesn't honour interrupted thread
status on KafkaConsumer.poll(Duration)
Key: KAFKA-16608
URL:
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-16608:
Assignee: Andrew Schofield
> AsyncKafkaConsumer doesn't honour interrupted
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840232#comment-17840232
]
Matthias J. Sax commented on KAFKA-16584:
-
I would prefer to make if configurable personally.
[
https://issues.apache.org/jira/browse/KAFKA-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16464.
---
Resolution: Duplicate
> New consumer fails with timeout in replication_replica_failure_test.py
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2073234352
re-trigger QA since some builds get terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576738178
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16461:
--
Description:
The {{security_test.py}} system test fails with the following error:
{quote}
* Consumer
[
https://issues.apache.org/jira/browse/KAFKA-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16462.
---
Resolution: Duplicate
> New consumer fails with timeout in security_test.py system test
>
CalvinConfluent commented on PR #15759:
URL: https://github.com/apache/kafka/pull/15759#issuecomment-2073486845
@mumrah @artemlivshits Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Kirk True created KAFKA-16609:
-
Summary: Update parse_describe_topic to support new topic describe
output
Key: KAFKA-16609
URL: https://issues.apache.org/jira/browse/KAFKA-16609
Project: Kafka
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2073680590
@lianetm @chia7712 Thanks for your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16608:
--
Summary: AsyncKafkaConsumer doesn't honor interrupted thread status on
KafkaConsumer.poll(Duration)
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ *
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073683927
@kirktrue Thanks for the heads-up!
If you have a moment, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577162256
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
+ *
showuon commented on PR #13953:
URL: https://github.com/apache/kafka/pull/13953#issuecomment-2073673074
@Kiriakos1998 , could you rebase with the latest trunk branch, and resolve
the conflicts? I'd like to see if it still passes.
--
This is an automated message from the Apache Git
kirktrue commented on PR #15784:
URL: https://github.com/apache/kafka/pull/15784#issuecomment-2073707108
@lucasbru/@cadonna —please review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1577056133
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static
showuon commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2073911312
Retriggering CI build :
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15616/11/
--
This is an automated message from the Apache Git Service.
To respond to the message,
CalvinConfluent opened a new pull request, #15792:
URL: https://github.com/apache/kafka/pull/15792
This is a mitigation fix for the
https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block
closing the producers. This PR reverts a part of the change #13591
CalvinConfluent opened a new pull request, #15791:
URL: https://github.com/apache/kafka/pull/15791
This is a mitigation fix for the
https://issues.apache.org/jira/browse/KAFKA-16217. Exceptions should not block
closing the producers. This PR reverts a part of the change #13591
kirktrue commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2073652156
@appchemist—thanks for the PR, and sorry for the delay in response!
I've taken a first pass but am still working through the unit test changes.
--
This is an automated message
vamossagar12 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2073698582
The build got aborted again 樂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1577073007
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -198,7 +177,7 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
showuon commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2073928078
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon merged PR #15748:
URL: https://github.com/apache/kafka/pull/15748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2073928975
Re-triggering CI build:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15787/3/
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577219150
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577220797
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java:
##
@@ -267,6 +267,18 @@ public String memberId() {
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073981282
@showuon thanks for the review and clarify scheduler behavior. Learn a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 merged PR #15714:
URL: https://github.com/apache/kafka/pull/15714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2074037067
@TaiJuWu Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2074099558
Opened #15793 to port it to v3.7 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
FrankYang0529 commented on code in PR #15773:
URL: https://github.com/apache/kafka/pull/15773#discussion_r1577187165
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -1343,6 +1346,45 @@ class LogManagerTest {
assertFalse(f.exists())
}
}
+
+ /**
github-actions[bot] commented on PR #15258:
URL: https://github.com/apache/kafka/pull/15258#issuecomment-2073953728
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073966870
> I think deletionTask must be executed. From LogManager#startup to
LogManager#startupWithConfigOverrides is not asynchronous code, so deletionTask
must be put into scheduler queue.
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971783
Re-trigger CI build:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15773/5/
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971106
>
If we want to use taskRunning to check whether deletionTask is executed,
we may need a new value in LogManager class to keep scheduler future object.
WDYT?
> I think
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577223693
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1577225484
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
1 - 100 of 156 matches
Mail list logo