Dinesh Premalal wrote:
Hi Damitha/All,
Damitha Kumarage <[EMAIL PROTECTED]> writes:
This is a good thing to do +1. We need to do a global replace in the
current code base.
I would like to keep the current code base as it is , and adapt for
new macro for future modifications. Because there may be others who
used this macro in their programs. Therefor replacing AXIS2_LOG_DEBUG
might not be a good choice.
+1. We cannot change the API, unless we want to go for 2.0.
I would suggest,
AXIS2_DEBUG_MSG(env->log, "[Project XYZ] Debug Message Tik Tak Too");
I am negative to changing the name of the macro. AXIS2_LOG_DEBUG is
fine as any othername anybody else come up with. Besides we have used
it for so long.
I would like to go with AXIS2_DEBUG_MSG because of the reason I stated
above.
But that does not follow out convention. AXIS2_ is the prefix, and LOG_
is the name of the struct. So as per our conventions it has to be,
AXIS2_LOG_DEBUG_MSG
Samisa...
thanks,
Dinesh
--
Samisa Abeysinghe
Director, Engineering; WSO2 Inc.
http://www.wso2.com/ - "The Open Source SOA Company"
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
