Hey Joey, Thanks for working to remove a quirk! Although we haven't written it into our compat principles <http://bit.ly/blink-compat>, I'm personally willing to accept greater compat risk for removing quirks as they're by-definition legacy behavior of the web which create an ongoing complexity burden for the platform which we should seek to eventually eliminate.
Reading through the history <https://github.com/whatwg/html/issues/2988#issuecomment-1271763702> of WebKit not being able to make this change due to severe breakage in bugzilla and seeing that we still load 12% of pages in quirks mode <https://chromestatus.com/metrics/feature/timeline/popularity/2034>, I don't think I can support proceeding without UseCounter data. Personally I would be happy to approve if we had a UseCounter with less than our small but non-trivial risk threshold <https://docs.google.com/document/d/1RC-pBBvsazYfCNNUSkPqAVpSpNJ96U8trhNkfV0v9fk/edit#heading=h.mqfkui78vo5z> of 0.001% of page loads. Based on Simon's previous HTTP Archive analysis <https://github.com/whatwg/html/issues/2988#issuecomment-326249793> you'll want to exclude the case where the strings match in your calculation. I think ignoring cases where the child text is empty is also fine as it'll avoid false positives with script updated DOM that Simon described and because replacing empty with non-empty string is almost certainly an improvement. WDYT? Rick On Thu, Jan 19, 2023 at 3:54 PM Joey Arhar <jar...@chromium.org> wrote: > > It's reassuring that this ships in Gecko, but do we have any sense of > how common it is to encounter an option w/ a label in quirks mode? > > I could add a use counter but I'm not sure what results would be > considered acceptable. > Apparently firefox only had one regression bug when they shipped this > behavior: > https://github.com/whatwg/html/issues/2988#issuecomment-1378794167 > > On Thu, Jan 19, 2023 at 12:18 PM Mike Taylor <miketa...@chromium.org> > wrote: > >> On 1/19/23 12:54 PM, Joey Arhar wrote: >> >> Contact emails jar...@chromium.org >> >> Specification https://github.com/whatwg/html/issues/2988 >> >> Summary >> >> Option elements support a "label" attribute which will cause the option >> to render with the text inside the attribute rather than the child text of >> the option element itself. This functionality is disabled in quirks mode, >> where the label attribute is ignored and the child text is always rendered. >> This change will always use the label attribute in both standards mode and >> quirks mode. >> >> >> Blink component Blink>Forms>Select >> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EForms%3ESelect> >> >> TAG review None >> >> TAG review status Not applicable >> >> Risks >> >> >> Interoperability and Compatibility >> >> If websites rely on this quirks mode behavior despite firefox already >> shipping this behavior for years, then select elements won't render with >> the expected text. If too many websites are broken, I will disable this >> change via finch and try to change the HTML spec to align with chrome. >> >> It's reassuring that this ships in Gecko, but do we have any sense of how >> common it is to encounter an option w/ a label in quirks mode? >> >> >> >> *Gecko*: Shipped/Shipping ( >> https://wpt.fyi/results/html/rendering/widgets/the-select-element/option-add-label-quirks.html >> ) >> >> *WebKit*: No signal >> >> *Web developers*: No signals >> >> *Other signals*: >> >> Ergonomics >> >> There are no other platform APIs that this change will be used in tandem >> with. >> >> >> Activation >> >> This will not be challenging for developers to take advantage of. >> >> >> Security >> >> There are no security risks/considerations for this feature. >> >> >> WebView application risks >> >> This change does not have particularly high risk to WebView. >> >> >> Debuggability >> >> No DevTools changes are needed for this change. >> >> >> Will this feature be supported on all six Blink platforms (Windows, Mac, >> Linux, Chrome OS, Android, and Android WebView)? Yes >> >> Is this feature fully tested by web-platform-tests >> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >> ? Yes >> >> Flag name --enable-features=OptionElementAlwaysUseLabel >> >> Requires code in //chrome? False >> >> Tracking bug >> https://bugs.chromium.org/p/chromium/issues/detail?id=1403735 >> >> Estimated milestones >> >> 111 >> >> >> Anticipated spec changes >> >> Open questions about a feature may be a source of future web compat or >> interop issues. Please list open issues (e.g. links to known github issues >> in the project for the feature specification) whose resolution may >> introduce web compat/interop risk (e.g., changing to naming or structure of >> the API in a non-backward-compatible way). >> >> >> Link to entry on the Chrome Platform Status >> https://chromestatus.com/feature/6084027289698304 >> >> This intent message was generated by Chrome Platform Status >> <https://chromestatus.com/>. >> -- >> You received this message because you are subscribed to the Google Groups >> "blink-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to blink-dev+unsubscr...@chromium.org. >> To view this discussion on the web visit >> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwLed%2BEECiebAa0bgXfLGVXNMMucLG%2B4667VnpJzeXXa8A%40mail.gmail.com >> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwLed%2BEECiebAa0bgXfLGVXNMMucLG%2B4667VnpJzeXXa8A%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BNO8ShF8nV1s1GDaryEpGGG%2B3M%2Bgw6qT%2Bxsfq%3DTwiG_w%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btw%2BNO8ShF8nV1s1GDaryEpGGG%2B3M%2Bgw6qT%2Bxsfq%3DTwiG_w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY-xp5FODC%3DDD%2BH_NaHGN0o9AM2ns7-RwLyUJWGeuHvpNA%40mail.gmail.com.
