On Mon, 7 Nov 2022 12:16:29 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to >> this one. >> >> Classfile API development is tracked at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch >> >> Development branch of consolidated JDK class files parsing, generating, and >> transforming is at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch >> >> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online >> API >> documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html) >> is also available. >> >> Please take you time to review this non-trivial JDK addition. >> >> Thank you, >> Adam > > make/test/BuildMicrobenchmark.gmk line 106: > >> 104: --add-exports java.base/jdk.classfile.components=ALL-UNNAMED \ >> 105: --add-exports java.base/jdk.classfile.impl=ALL-UNNAMED \ >> 106: --add-exports >> java.base/jdk.internal.org.objectweb.asm=ALL-UNNAMED \ > > Why do you need to export ASM now, when it was not needed before? I thought > the purpose here was to replace ASM..? There are new benchmarks added, comparing performance of Classfile API with ASM. ------------- PR: https://git.openjdk.org/jdk/pull/10982
