On Mon, 7 Nov 2022 13:01:41 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> make/modules/java.base/Java.gmk line 37:
>> 
>>> 35: 
>>> 36: EXCLUDES += java/lang/doc-files
>>> 37: EXCLUDES += jdk/classfile/snippets
>> 
>> I don't like hard-coded excludes like this. Is this the first real-world 
>> example of snippets in the JDK? If not, how has this been resolved in other 
>> instances? Maybe we need a more general method to exclude snippets from 
>> compiling.
>
> I'll fix it, thanks.

Unfortunately I found only two use cases of external snippets in JDK. One is 
explicitly excluding the snippets package and the other does not care, so the 
snippets are included.

-------------

PR: https://git.openjdk.org/jdk/pull/10982

Reply via email to