On Sat, 26 Nov 2022 18:42:39 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Unfortunately I found only two use cases of external snippets in JDK. One is >> explicitly excluding the snippets package and the other does not care, so >> the snippets are included. > > Is the practice of naming the directory `snippets` well-established or > mandated? Otherwise I think a name like `snippet-files` (akin to `doc-files`) > would be much better, since it indicates that is not a java package name. > (These do not usually include `-`; I am unsure if this is prohibited by the > specification, or just not used by convention.) > > In fact, when checking, I see that there is already a handful of > `snippet-files`: > > ./jdk.jfr/share/classes/jdk/jfr/snippet-files > ./jdk.jfr/share/classes/jdk/jfr/consumer/snippet-files > ./java.compiler/share/classes/javax/tools/snippet-files > > > So maybe rename it to `snippet-files`, and I'll look into making exclusion of > `snippet-files` be done automatically. It would be nice to get the directory excluded by default. I used the snippet-files name since it was mentioned in the JEP https://openjdk.org/jeps/413 ------------- PR: https://git.openjdk.org/jdk/pull/10982
