On Mon, 28 Sep 2026 09:35:13 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Reuben Roessler has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use shorthand equality check for collation > > src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 404: > >> 402: } >> 403: >> 404: } > > Shouldn't we do the same in PSPrinterJob and we will need a manual test, > maybe similar to what we have for Banner options > test/jdk/java/awt/print/PrinterJob/BannerTest.java > or maybe > test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java will do, in > which case this JBS id needs to be added to that test!! >From what I can see `PSPrinterJob.java` already supports collation: https://github.com/openjdk/jdk/blob/4798413be61d7e86f0ce5370b95fe157b6d9b28e/src/java.desktop/share/classes/sun/print/PSPrinterJob.java#L619 I will add the JBS id for `Collate2DPrintingTest.java` which should suffice when testing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33023#discussion_r4128854498
