juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2216135919
##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
command_dir = build_root
sandbox.set_work_directory(command_dir)
- # Setup environment
- sandbox.set_environment(self.get_environment())
-
def stage(self, sandbox):
+ # Setup environment
Review Comment:
Setting up the environment in `stage()` is a problem at least for `bst shell
--build --use-buildtree`, which does not invoke `Element.stage()` but still
requires environment variables to be set.
Draft fix for the overlap collector issue and moving environment setup back
to `configure_sandbox()`:
https://github.com/apache/buildstream/commits/jbilleter/digest-environment/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
