gtristan commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2239202923


##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
             command_dir = build_root
         sandbox.set_work_directory(command_dir)
 
-        # Setup environment
-        sandbox.set_environment(self.get_environment())
-
     def stage(self, sandbox):
+        # Setup environment

Review Comment:
   It looks to me that we do actually cache the environment variables in the 
artifact metadata, it seems to me that we should be relying on that in `bst 
shell --build --use-buildtree`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to