juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2263226154
##########
src/buildstream/sandbox/_sandboxremote.py:
##########
@@ -263,9 +263,17 @@ def _execute_action(self, action, flags):
"Uploading input root", element_name=self._get_element_name()
):
# Determine blobs missing on remote
+ root_digests = [action.input_root_digest]
+
+ # Add virtual directories for subsandboxes
+ for subsandbox in self._get_subsandboxes():
+ vdir = subsandbox.get_virtual_directory()
+ root_digests.append(vdir._get_digest())
Review Comment:
I also think it's not worth it. The files in subsandboxes should typically
be a subset of the main input root, so the overhead should just be a few
`Directory` protobuf messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
