juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2278799213
##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
command_dir = build_root
sandbox.set_work_directory(command_dir)
- # Setup environment
- sandbox.set_environment(self.get_environment())
-
def stage(self, sandbox):
+ # Setup environment
+ env = self.get_environment()
+
+ # Add "CAS digest" environment variables
+ sorted_envs = sorted(self.__digest_environment)
+ for digest_variable in sorted_envs:
+ element_list = [element for element, _ in
self.__digest_environment[digest_variable]]
+ subsandbox = sandbox.create_subsandbox()
+ self.stage_dependency_artifacts(subsandbox, element_list)
Review Comment:
The loader takes care of sorting dependencies via
`loadelement.sort_dependencies()` early on, so `Element` and its subclasses
never even have access to the declaration order and thus, there is no such
issue, as far as I can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
