juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2231470958
##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
command_dir = build_root
sandbox.set_work_directory(command_dir)
- # Setup environment
- sandbox.set_environment(self.get_environment())
-
def stage(self, sandbox):
+ # Setup environment
Review Comment:
I've pushed the fix to this branch and it seems to work well for normal
builds. However, it still doesn't work for `bst shell --build --use-buildtree`
(see failing test case) as that skips the loading of dependency artifacts.
Always requiring build dependencies to be available for `bst shell --build
--use-buildtree` would fix the test case but I suspect it would break buildtree
shells for artifacts. Any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
