juergbi commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2241800998
##########
src/buildstream/buildelement.py:
##########
@@ -285,10 +305,20 @@ def configure_sandbox(self, sandbox):
command_dir = build_root
sandbox.set_work_directory(command_dir)
- # Setup environment
- sandbox.set_environment(self.get_environment())
-
def stage(self, sandbox):
+ # Setup environment
Review Comment:
The intention is to recommend the latter, i.e., use the remote execution
protocol even for local execution, as the former (cache-only) is much easier to
get wrong and get incorrect cache hits due to incomplete cache keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
