hudi-agent commented on code in PR #19492:
URL: https://github.com/apache/hudi/pull/19492#discussion_r3709905246


##########
packaging/hudi-timeline-server-bundle/pom.xml:
##########
@@ -146,6 +146,8 @@
             <version>${maven-shade-plugin.version}</version>
             <configuration>
                 <createDependencyReducedPom>true</createDependencyReducedPom>
+                
<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml

Review Comment:
   🤖 nit: could you keep the closing tag on the same line 
(`<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation>`)?
 Wrapping it puts a trailing newline/whitespace inside the element value and 
reads a bit awkwardly.
   
   <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to