rangareddy commented on PR #19492:
URL: https://github.com/apache/hudi/pull/19492#issuecomment-5305906134
Rebased onto current master, squashed to a single commit, and that push
retriggered the workflows.
**The two that were not running are running now.** Before the push the PR
had only `detect-trino-changes`, `test-hudi-trino-plugin` and the three
`validate-pr*` checks; `changes` and `validate-source` were absent, and so was
`validate-ci-baseline`. The branch was still on the pre-trim base and its last
run was 2026-08-04, when Actions was disabled on the repo — so it never picked
up the workflow set from #19514/#19523. All three now report, along with the
full Java CI matrix.
**Review comments:** all three were already settled, and I re-checked rather
than assumed. The two `hudi-io` comment nits are applied — it is four lines
now, no "iff", no defensive aside. The `dependencyReducedPomLocation` wrapping
stays declined, and the recount backs it: **16** `packaging/*` bundles use the
wrapped form, **0** use a single line, so unwrapping would make this the one
bundle formatted differently — which works against the point of the change.
**Two inconsistencies I found and fixed while squashing**, both mine:
- the squashed commit message said `Closes #19466`, which contradicts the PR
body ("**Does not close it**") and would have auto-closed the issue on merge.
It now says "Partial fix ... deliberately not Closes", and names what is
missing (the hoist).
- the body still described the `hudi-io` comment as stating the invariant
"`false` is correct **iff** the shaded jar is attached under a classifier" —
wording that the trim removed two rounds ago. Corrected, with a note that it
was trimmed.
Re-verified after the rebase: all three POMs resolve, and
`packaging/hudi-timeline-server-bundle` writes its reduced POM to
`target/dependency-reduced-pom.xml` (7114 bytes) with the module root clean —
the behaviour the change exists for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
