rangareddy commented on code in PR #19492:
URL: https://github.com/apache/hudi/pull/19492#discussion_r3710542877
##########
packaging/hudi-timeline-server-bundle/pom.xml:
##########
@@ -146,6 +146,8 @@
<version>${maven-shade-plugin.version}</version>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
+
<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml
Review Comment:
Declining this one, with evidence — the wrapping is deliberate and matches
every sibling.
All 15 other `packaging/*` bundles that set this flag use exactly the
wrapped form; **none** uses a single line:
```
$ grep -rn -A1 "<dependencyReducedPomLocation>" packaging/*/pom.xml | grep
-c "dependency-reduced-pom.xml$"
15
$ grep -rn "<dependencyReducedPomLocation>.*</dependencyReducedPomLocation>"
packaging/*/pom.xml | wc -l
0
```
The whole point of this change is that `hudi-timeline-server-bundle` was the
one bundle missing the flag, so making it the one bundle formatted differently
would work against it.
You are right that the wrapped form puts whitespace inside the element
value; Maven trims it, and I verified the behaviour rather than assuming —
after the change the reduced POM lands at `target/dependency-reduced-pom.xml`
(7114 bytes) instead of the module basedir, which is the whole effect being
sought.
Happy to switch all 16 to single-line as a separate formatting change if
that is preferred, but not to make this one an outlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
