SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5658078202
@KaustAbhinand thanks for linking the GraphQL connector migration PR here — that closes the loop on the earlier request to link it back to this issue. I'll take a look on the PR itself; please keep any further scope or review discussion there rather than in this thread, so the tracking issue stays readable. Nothing else is needed from you on this issue for now. @1328837476-hug thanks for opening the GoogleFirestore sink validation PR and for summarizing the contract (`project_id` and `collection` required and nonblank, `credentials` optional but rejecting an explicitly blank value, factory-level regression cases, EN/ZH docs, no credential parsing/format/SDK/remote/runtime changes, rebased onto `dev` before opening). That matches the agreed slice. Review feedback will go on the PR directly. <!-- streview-comment:1024 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
