SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5673817255
@KaustAbhinand thanks for linking it here — having #12273 referenced on this thread is exactly what we need so the GraphQL connector slice is traceable from the umbrella issue. A few things to close out on your side so review can move quickly: - Please make sure the PR description itself links back to this issue, and that the title/description clearly states it is the GraphQL connector declarative validation migration only (no unrelated connectors or runtime behavior changes). - Confirm the PR targets `dev` and is rebased on the latest `dev`. - List in the PR description which options are now registered as required vs optional, and point to the focused factory-level regression tests covering valid, missing, and empty/whitespace-only values. - If EN/ZH connector docs were touched, call that out; if not, please say why no doc change was needed. You mention CI has passed and that the PR has already been looked at — I will verify the current state directly on the PR rather than here. Please keep any further scope or review discussion on #12273 itself so this issue thread stays focused on tracking claims and linked PRs. <!-- streview-comment:1054 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
