SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5707685944
@Nikk8091 thanks for opening #12315 for the connector-sensorsdata sink slice. The described scope matches what was agreed here: `server_url` registered as required with a nonblank constraint (covering valid, missing, empty, and whitespace-only values), `consumer` registered as optional with explicit `batch`/`console` cases plus the omitted-`consumer` default to `batch`, and no changes to SDK, format, network, timeout, retry, or runtime behavior. A few remaining asks before review on that PR: - Please confirm the PR is limited to the `SensorsDataSDKSinkFactory` option registration/validation change, the focused factory tests you listed, and the matching EN/ZH docs, with nothing else touched. - Please confirm it targets `dev` and links back to this issue so the tracking stays in one place. - Keep any further scope or review discussion for the SensorsData slice on #12315 rather than in this thread. Once those are confirmed I'll pick up the review there. <!-- streview-comment:1111 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
