DanielLeens commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5775025119
@SEZ9 the F2 confirmation is in my review on commit 06c2ef03e: https://github.com/apache/seatunnel/pull/11727#pullrequestreview-5254567038, under the "Response to the open @SEZ9 items" section: > F2: confirmed. The worker reads taskGroupExecutionTracker.context (:1294); that field is private final (:1561), assigned once in the constructor (:1568) from the same object that deployLocalTask() builds at :700-703. It is named context on this branch (not ownedContext). The shared-map lookup and its null-context branch are gone from BlockingWorker. That review was on 06c2ef03e, before the dev merge that produced the current head (a80834ebf). As noted in the same review and confirmed by @abdessalems, none of the dev commits pulled in by that merge touch the three files changed in this PR, so the F2 finding still applies unchanged to the current head - nothing to re-verify there. On the engine-v2-it failure: agreed, that is the dev-side SplitClusterFaultToleranceIT race tracked in #12311, not something this PR or the dev sync could fix, so I would not block on it either. Thanks for tracking this down carefully across all these rounds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
