SEZ9 commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5788006108
Noting the dev sync: since `a80834ebf` carries the same patch content as `06c2ef03e`, the merge itself doesn't need a fresh pass from me. What I still need is a pointer for each of the earlier `TaskExecutionService` findings, since I can't tell from this thread which of them landed on the current head: - **PR11727-F1 / F3 / F5** – `deployLocalTask()` installs the context and cancellation future with a plain `put` outside the `TaskExecutionService.this` monitor that `finishOwnedResources()` claims to share, so the redeploy-vs-taskDone race on `cancellationFutures` / async functions / timer flushes isn't actually closed, and a still-live older generation can be silently overwritten. Please either take the monitor around the installation (and reject/handle a live older entry instead of overwriting it) and align the Javadoc, or point me to where this was changed. - **PR11727-F2** – `BlockingWorker` should resolve its context from the tracker's `ownedContext` rather than the shared `executionContexts` map, so it can't pick up a newer generation's context/class loader for a reused `TaskGroupLocation`. - **PR11727-F4 / F8** – the stale-cleanup branch should also cancel the old generation's async functions and timer-flush tasks and move `ownedContext` into `finishedExecutionContexts`; the redundant `get` before `remove(key, value)` in `finishExecutionContext()` can be dropped. - **PR11727-F6** – if the class-loader release and cancellation work stays under the service-wide monitor, a short note on why that's acceptable would help; otherwise move the heavy teardown outside the lock. - **PR11727-F7** – a test exercising the redeploy-vs-taskDone race on `cancellationFutures` in `TaskDeployStaleContextRaceTest` would round this out, ideally with less reflection into internals. If some of these are already in `06c2ef03e`, a one-line reply per item with where to look is enough and I'll verify against `a80834ebf`. <!-- streview-comment:1247 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
