SEZ9 commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5852059978
Thanks, @201811510411lw — that settles the checkpoint-failure question for me. Reproducing the same fault-injection timing race on the parent `1650a04cd` is exactly the evidence needed to rule it out as routing-related, and splitting it into its own targeted test fix in #12449 (3/3 on Java 8, 3/3 on Java 11) rather than folding it into the routing PR is the right call. I'll follow that one there. Nothing new has landed on this branch (head is still `48264cda6a`, the `986638204fc` fix plus the two upstream-dev merges), so I'm not doing a fresh review here. Two small asks so we keep the record clean: 1. Since you've confirmed the routing implementation is now maintained in #12366 only, could you either close this PR or add a short note in the description pointing to #12366 as the successor? That avoids anyone picking this branch up by mistake. 2. When #12449 is ready, please drop a one-line link on #12366 so the checkpoint fix and the routing PR are cross-referenced for whoever reviews the CI there. I'll continue the review on #12366 and #12449 and will take a fresh look here right away if anything new does land on this PR specifically. <!-- streview-comment:1348 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
