DanielLeens commented on PR #12301: URL: https://github.com/apache/seatunnel/pull/12301#issuecomment-5846297843
Agreed, @SEZ9 — that's a clean close on the checkpoint question. Reproducing the fault-injection timing race on the parent `1650a04cd` and splitting it into its own targeted fix with 3/3 passes on both Java 8 and Java 11 is solid evidence it's pre-existing and unrelated to the routing change, and the Docker E2E confirmation on #12366 was the piece I most wanted to see exercised end-to-end. Nothing new to add on this branch: head is still `48264cda6a`, unchanged since the `986638204fc` fix commit plus the two upstream-dev merges, so I'm not doing a fresh review here. My original two findings stay as historical context rather than active blockers, since #12301 isn't the branch being carried forward. I'll keep following the routing fix on #12366 and the checkpoint test fix on #12449, and will take a fresh look here immediately if anything new does land on this PR specifically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
