SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5903266797
@yigitcan-ozturk thanks for the update — the RabbitMQ Sink `queue_name` slice is done now that it entered `dev` at `463adf8c47aab1f9da8f135121917281870d9b97`, so please don't open a follow-up for that exact scope. On your connector-clickhouse claim, a couple of things before you start implementing: - The ClickhouseFile single-character delimiter move to `optionRule` is already represented by an open PR that is currently blocked on a failed Build. Please treat that piece as taken and don't open a duplicate; if you want to help there, comment on that PR rather than re-doing the change. - For the remaining Clickhouse Source/Sink validation paths, "declarative-eligible rules" is still too broad for us to sign off on. Please post here, before any code, (1) the current `dev` behavior for each option you plan to touch (which checks exist today, where they run, and what they reject), (2) the exact declarative constraints you propose for each, and (3) the focused factory/`ConfigValidator` test boundary (valid, missing, empty, whitespace-only, padded nonblank, and any numeric bounds), plus an explicit list of behavior that stays unchanged (connection, sharding, remote checks, etc.). - Keep it to one focused slice per PR so it can be reviewed and merged independently. Once that audit is posted we can confirm the scope and you can go ahead. <!-- streview-comment:1423 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
