SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5944448141
@karthik-0306 thanks for opening https://github.com/apache/seatunnel/pull/12573 — that matches the agreed Paimon scope (declarative `notBlank` on `warehouse`/`database`/`table` across the source, sink, and catalog factories), and it now owns that slice, so nobody else should open a duplicate for it. A few things to close out before it can move forward: 1. The PR is currently showing a failing Build. Please take a look at the failure and push a fix (or let us know on the PR if it looks unrelated to your change). 2. Please make sure the PR includes factory/`ConfigValidator`-level tests for each of the three options covering a valid value, missing, empty, whitespace-only, and a padded non-blank value, so the regressions are protected for source, sink, and catalog alike. 3. Confirm in the PR description that nothing beyond the three `notBlank` conditions changed (no behavior changes to catalog/table creation, schema handling, or runtime paths), and that EN/ZH docs for the Paimon connector are consistent with the new validation. Once the Build is green and the tests/docs are in place, drop a note here and we'll review it. <!-- streview-comment:1456 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
