SEZ9 commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6871202966

   Thanks @CryoThrust for running the fork Build on the unchanged head 
`55831abaef1e1aac58988977c1da8e73a27d9417` 
(https://github.com/CryoThrust/seatunnel/actions/runs/43151029739) and for 
pulling out the test-report details.
   
   On CI:
   
   - **SFTP E2E (JDK 11/17):** this is the image-tag problem already fixed in 
`dev` (`379292194cc9ee9ecba2f6adf07cefcc94a7db21`). Please sync this branch 
onto latest `dev` rather than adding any SFTP-related change here.
   - **Engine E2E (JDK 11):** 
`BackpressureSlowSinkIT#testCheckpointsKeepCompletingUnderSustainedBackpressure`
 observing only two additional checkpoints in its 90-second window 
([job](https://github.com/CryoThrust/seatunnel/actions/runs/43151029739/job/130963521636))
 is not explained by the SFTP fix, and I agree it should not be treated as 
green. After the sync, please rerun and, if it still fails, attach the new test 
report so we can tell whether it is flakiness or something this PR touches. 
Please don't loosen that assertion or add unrelated changes to this CLI PR to 
get CI green.
   
   Separately from CI, the review findings on the validate command are still 
open and are what gates this PR from my side:
   
   1. **F1 (HIGH):** the static-validation failure path must not re-attach the 
unsanitized exception as the cause of the thrown `ConfigCheckException`; 
otherwise the credential sanitization is bypassed by anyone who prints the 
cause/stack trace.
   2. **F3:** guard against a null exception message before sanitizing it, so 
the thrown exception is covered, not only the JSON payload.
   3. **F2:** confirm the JSON output is produced by a real JSON serializer so 
error messages are always correctly escaped.
   4. **F4 / F6:** in JSON mode stdout should contain only the JSON document — 
the failure path should not also propagate `ConfigCheckException` and 
interleave text-mode logging, and the success-JSON emission should live outside 
the `try` so a serialization problem isn't reported as a config validation 
failure (or throw again inside the `catch`).
   5. **F5:** either keep `FileUtils.getConfigPath()` outside the `try` for the 
default text mode, or call out the exception-type/message change explicitly as 
intended.
   6. **F7:** document the `schemaVersion` / `valid` / `phase` / `errors` 
contract in `user-command.md`.
   7. **F8 (LOW):** collapse the duplicated failure-JSON blocks and add 
explicit grouping to the mixed `&&`/`||` condition.
   
   If any of these are already addressed in a commit I haven't seen yet, just 
point me at it and I'll re-check. Once the branch is synced and those items are 
in, I'll do another pass together with the fresh Build result.
   
   <!-- streview-comment:2347 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to