SEZ9 commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6889175191

   Quick summary of where things stand on this PR.
   
   **CI:** The automated review note is right that the earlier "no fork Build 
executed" statement is stale — the Build at run `43151029739` did execute on 
head `55831abaef1e1aac58988977c1da8e73a27d9417` and failed in the SFTP E2E 
lanes (JDK 11/17) and the JDK 11 engine E2E lane. The SFTP failures are the 
fixture image tag problem already fixed in `dev` by #13203 
(`379292194cc9ee9ecba2f6adf07cefcc94a7db21`), so please just sync latest `dev` 
and rerun; no SFTP-related change belongs in this CLI PR. The engine lane (job 
`130963521636`) timing out in 
`BackpressureSlowSinkIT#testCheckpointsKeepCompletingUnderSustainedBackpressure`
 is not explained by the image fix. If it recurs on the synced head, please 
link the new failing lane and test report here — and please don't touch that 
assertion or add unrelated changes to get green.
   
   **Review scope:** CI aside, the findings from the previous review on 
`SeaTunnelConfValidateCommand.java` and `user-command.md` are still what gates 
this from my side. I don't see an update addressing them yet, so to be concrete:
   
   1. **F1 (HIGH)** – the static-validation failure path must not re-attach the 
unsanitized exception as the cause of the thrown `ConfigCheckException`; 
otherwise the sanitization is bypassed.
   2. **F2** – ensure the sanitized messages placed in the JSON `errors` array 
are JSON-escaped by the serializer (not string-concatenated).
   3. **F3** – apply the null guard before calling `sanitize(message)` so the 
thrown exception is covered too, not only the JSON payload.
   4. **F4** – in JSON mode, stdout should contain only the JSON document; the 
failure path currently still propagates `ConfigCheckException` and text-mode 
logging can interleave.
   5. **F5** – moving `FileUtils.getConfigPath()` into the try block changes 
the exception type/message for missing config files in default text mode; 
please preserve the previous behavior there.
   6. **F6** – move the success JSON emission out of the try block so a 
serialization failure isn't reported as a config validation failure (and can't 
throw again inside the catch).
   7. **F7** – document the JSON schema (`schemaVersion`, `valid`, `phase`, 
`errors`) in `docs/en/engines/zeta/user-command.md`.
   8. **F8** – dedupe the two failure-JSON emission blocks and add explicit 
grouping to the mixed `&&`/`||` condition.
   
   Once you've pushed the sync plus these changes, drop a short note mapping 
each of F1–F8 to how it was resolved (or why you disagree) and I'll re-review 
promptly. Thanks for sticking with this.
   
   <!-- streview-comment:2369 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to