SEZ9 commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-7025133947

   Thanks for extending the real launcher test to cover an internal validation 
failure. Here is where the earlier review points stand after the latest 
re-review.
   
   **Resolved in the current source**
   
   - **Raw cause in text mode:** text mode now throws a sanitized validation 
exception without the raw cause.
   - **JSON escaping:** the structured result uses Jackson tree construction 
rather than string concatenation.
   - **stdout in JSON mode:** `ConfigCheckException` is no longer propagated to 
the generic text logger. The bash launcher scans for `--format json` and sets 
the console target to `SYSTEM_ERR` before Log4j starts. Custom or native 
launchers keep the documented configuration responsibility.
   - **Text-mode compatibility:** default text output remains selected and its 
path-resolution exception behavior is preserved.
   - **Serialization placement:** serialization happens once, after the 
validation result is formed.
   
   **Still to confirm**
   
   1. **Null exception message:** could you confirm that sanitization is safe 
when the exception message is null, for both the JSON payload and the thrown 
`ConfigCheckException`? A small test for a null-message failure would settle 
this.
   2. **Docs:** could you confirm that the JSON output schema (`schemaVersion`, 
`valid`, `phase`, `errors`) is documented in `user-command.md`? It is a 
versioned, machine-readable contract.
   3. **Readability:** could you confirm that the duplicated failure-JSON 
emission blocks are gone, and that the mixed `&&`/`||` condition was either 
removed or given explicit grouping?
   
   CI on the current head is separate from the points above.
   
   <!-- streview-comment:2468 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to