SEZ9 commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6962567809

   Thanks @CryoThrust for the follow-up in `90fd7b7eb`.
   
   **Sounds right, but not yet confirmed against the diff**
   
   - **F1:** Omitting the original cause on validation failures in text mode is 
the direction I asked for, and `testStaticTextFailureDoesNotExposeRawCause` as 
you describe it (full printed stack trace, including a credential in the nested 
cause) is the coverage I wanted. I'll keep this open until I've confirmed it in 
the diff.
   - **F3:** `testStaticTextNullMessageUsesFallback` asserting the text-mode 
`ConfigCheckException` message `Static analysis failed: Validation failed` 
sounds like the right check. This one also stays open until I've confirmed it 
in the diff.
   
   **Remaining asks**
   
   - **F8 (grouping):** The finding was filed against 
`SeaTunnelConfValidateCommand.java`, while the expression you quote is in 
`ClientCommandArgs`. Is there a mixed `&&`/`||` condition without explicit 
grouping in `SeaTunnelConfValidateCommand.java` itself, or is the 
`ClientCommandArgs` expression the only one?
   - **F8 (duplication):** What is the status of the duplicated failure-JSON 
emission blocks?
   - **F4:** The Bash-only note in the guides and the new text-mode failure 
check are useful. The original concern was narrower, though: in JSON mode, 
stdout must contain only the JSON document on the failure path. Do the existing 
JSON failure checks assert that stdout is exactly one parseable JSON document, 
with no log or error text interleaved? If not, please add that assertion.
   - **F5:** You mention that the pre-validation path-resolution exception 
contract "remains covered separately". Does that mean the exception type and 
message for a missing or unresolvable config file in default text mode are 
unchanged from before this PR? Please name the test that pins this.
   - **F2, F6, F7:** Your comment doesn't mention these, so could you give a 
short status for each?
     - **F2:** How is JSON escaping guaranteed for the sanitized messages 
embedded in the output?
     - **F6:** Is the success JSON emission still inside the try block, where a 
serialization failure would be reported as a validation failure?
     - **F7:** Is the output schema (`schemaVersion`, `valid`, `phase`, 
`errors`) now documented in `user-command.md`?
   
   <!-- streview-comment:2418 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to