CryoThrust commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6937564087

   Thanks for the clarification. Pushed `90fd7b7eb` on top of `ce93a3a44`.
   
   - **F1:** You were right: sanitizing the outer message did not make the 
original text-mode cause safe. Validation failures now omit that cause in text 
mode too. `testStaticTextFailureDoesNotExposeRawCause` checks the complete 
printed stack trace against password/token values in the original exception and 
a credential in its nested cause. It fails before the fix and passes after it. 
The existing pre-validation path-resolution exception contract remains covered 
separately.
   - **F3:** Added `testStaticTextNullMessageUsesFallback`, which makes 
`ConfigBuilder` throw a message-less exception and asserts the actual text-mode 
`ConfigCheckException` message is `Static analysis failed: Validation failed`. 
This verifies the text path directly, rather than only inspecting a JSON result.
   - **F4:** Both command guides now explicitly state that the launcher 
integration test covers Bash and does not cover native Windows launchers. The 
updated real Zeta/Bash test also checks a text-mode failure: a 
credential-bearing invalid config value produces a sanitized diagnostic, exit 
status 1, and no raw credential in either stdout or stderr. Its existing JSON 
success/failure checks remain.
   - **F8:** The expression I meant is [ClientCommandArgs, lines 289 
onward](https://github.com/CryoThrust/seatunnel/blob/90fd7b7eb2ccaf683cb6e9d38487351e61babf90/seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/args/ClientCommandArgs.java#L289):
 `outputFormat == OutputFormat.JSON && ((!checkConfig && dryRun == null) || 
dryRun == DryRun.SAMPLE)`. Those parentheses were already present at 
`ce93a3a44`; my earlier reply was a source clarification, not a claimed change 
to that expression.
   
   JDK 11 verification passes: 67 starter/argument/launcher cases, 3 JSON 
schema cases, and the updated Zeta/Bash integration test, all without skips. 
Formatting and both changed modules' skip-tests verification also pass. The 
[new-head 
Build](https://github.com/CryoThrust/seatunnel/actions/runs/44012181068) is 
queued; the description reflects this scope.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to