SEZ9 commented on PR #12101: URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6992294665
Quick status update on where this stands. The Build run for the unchanged head (run 44220308134) went from queued to cancelled, so it did not produce a successful result for this revision. This clarification adds no new source finding. The stdout issue from the earlier review is still the blocker. In JSON mode, stdout is not guaranteed to contain only the JSON document, because the failure path still propagates `ConfigCheckException` and the existing text-mode logging and error handling can interleave with the JSON. Remaining asks: 1. Push a fix so that JSON mode emits only the JSON document on stdout, including on the validation-failure path. 2. Get a completed Build on the head that contains that fix, since the cancelled run can't stand in for it. Could you also add a short note on how you handled the failure path (where the exception and the log output end up in JSON mode)? That will make the re-check quicker. Thanks for sticking with this one! <!-- streview-comment:2436 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
