Cool.. I think you know then the path to fix the rest? The unicode seems to make sense to me.
On the second part, is there ever a time we would want to send a null message? I can't think of one really, and the point of Email is to hide the complexity from you, so that sounds good to me.. Eric > -----Original Message----- > From: Corey Scott [mailto:[EMAIL PROTECTED] > Sent: Friday, October 29, 2004 4:05 PM > To: Jakarta Commons Developers List > Subject: Re: [email] test cases > > > Guys, > > I need some guidance. The test cases mentioned are failing for a > couple of reasons. The ones that are failing are doing so because the > personal names are still using ? instead of an invalid unicode > character, we can replace them with something like \uc5ec (this is > korean i believe) they will then pass properly. > > One of the others is failing due to lack of content and this is > because the functions are allowing this to set, I would like to > propose changing the (MultipartEmail) setMsg, setHTML, etc. to throw a > MessagingException on null message. This will bring them in line with > HtmlEmail which is already doing this. This would also mean changing > the test array of strings (thanks eric!!!) by removing the null. > > If this is all ok, I will happily generate a patch for these changes. > > Thanks, > Corey > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
