On Tue, 3 Feb 2026 22:09:58 GMT, Justin Lu <[email protected]> wrote:

> This PR consists of a conversion for the java/util/zip TestNG tests to JUnit. 
> Changes are mainly automated. 
> https://github.com/openjdk/jdk/commit/1aeb8a634b8f255853516015f4b39bd79dd94090
>  is required to resolve a failure since JUnit parameterized tests 
> automatically close arguments that implement `AutoCloseable`.
> 
> Test stats before:
> Framework-based tests: 274 = 107 TestNG + 167 JUnit
> 
> Test stats after:
> Framework-based tests: 274 = 0 TestNG + 274 JUnit

test/jdk/java/util/zip/CloseInflaterDeflaterTest.java line 93:

> 91: 
> 92:     /**
> 93:      * DataProvider to specify on which outputstream closeEntry() has to 
> be called

It would be good to do a pass over the comments to replace the uses of 
DataProviders as these methods are now method sources.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2762615206

Reply via email to