On Tue, 3 Feb 2026 22:09:58 GMT, Justin Lu <[email protected]> wrote: > This PR consists of a conversion for the java/util/zip TestNG tests to JUnit. > Changes are mainly automated. > https://github.com/openjdk/jdk/commit/1aeb8a634b8f255853516015f4b39bd79dd94090 > is required to resolve a failure since JUnit parameterized tests > automatically close arguments that implement `AutoCloseable`. > > Test stats before: > Framework-based tests: 274 = 107 TestNG + 167 JUnit > > Test stats after: > Framework-based tests: 274 = 0 TestNG + 274 JUnit
test/jdk/java/util/zip/DeflaterDictionaryTests.java line 37: > 35: > 36: import static java.nio.charset.StandardCharsets.UTF_8; > 37: import static org.junit.jupiter.api.Assertions.assertThrows; Maybe a combination of the TestNG test and the migration tool but it seems a bit strange to static import assertThrows and uses Assertions.assertXXX for everything else. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2762623998
