On Tue, 3 Feb 2026 22:09:58 GMT, Justin Lu <[email protected]> wrote:
> This PR consists of a conversion for the java/util/zip TestNG tests to JUnit.
> Changes are mainly automated.
> https://github.com/openjdk/jdk/commit/1aeb8a634b8f255853516015f4b39bd79dd94090
> is required to resolve a failure since JUnit parameterized tests
> automatically close arguments that implement `AutoCloseable`.
>
> Test stats before:
> Framework-based tests: 274 = 107 TestNG + 167 JUnit
>
> Test stats after:
> Framework-based tests: 274 = 0 TestNG + 274 JUnit
Thank you for starting the migration of the zip, jar, and zipfs tests
A few comments on initial pass
test/jdk/java/util/zip/DeflaterDictionaryTests.java line 24:
> 22: */
> 23:
> 24:
Please update the copyright date
test/jdk/java/util/zip/DeflaterDictionaryTests.java line 69:
> 67: * @return invalid offset values
> 68: */
> 69: protected static IntStream invalidDictionaryOffsets() {
Please update comment to remove DataProvider
test/jdk/java/util/zip/DeflaterDictionaryTests.java line 112:
> 110: inflater.getAdler(), resultLength);
> 111:
> 112: Assertions.assertEquals(resultLength, SRC_DATA.length());
Please import the methods as done in other tests
test/jdk/java/util/zip/GZIP/GZIPOutputStreamHeaderTest.java line 25:
> 23:
> 24:
> 25: import org.junit.jupiter.api.Assertions;
Can we import the specific methods to be consistent with the other tests
-------------
PR Review: https://git.openjdk.org/jdk/pull/29552#pullrequestreview-3751760455
PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2764713283
PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2764725246
PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2764734375
PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2764625412
