On Wed, 4 Feb 2026 18:58:44 GMT, Justin Lu <[email protected]> wrote: >> This PR consists of a conversion for the java/util/zip TestNG tests to >> JUnit. Changes are mainly automated. >> https://github.com/openjdk/jdk/commit/1aeb8a634b8f255853516015f4b39bd79dd94090 >> is required to resolve a failure since JUnit parameterized tests >> automatically close arguments that implement `AutoCloseable`. >> >> Test stats before: >> Framework-based tests: 274 = 107 TestNG + 167 JUnit >> >> Test stats after: >> Framework-based tests: 274 = 0 TestNG + 274 JUnit > > Justin Lu has updated the pull request incrementally with three additional > commits since the last revision: > > - Fixing other 'DataProvider' occurrences in JUnit tests under java/util/zip > - Correct previous incorrect placement of actual/expected in assertions > (Chen) > - Use static imports everywhere + fix 'DataProvider' in comments (Alan, > Lance)
Thank you Justin. The changes look good overall ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29552#pullrequestreview-3753063408
