On Wed, 4 Feb 2026 04:04:07 GMT, Chen Liang <[email protected]> wrote:
>> Justin Lu has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Fixing other 'DataProvider' occurrences in JUnit tests under java/util/zip >> - Correct previous incorrect placement of actual/expected in assertions >> (Chen) >> - Use static imports everywhere + fix 'DataProvider' in comments (Alan, >> Lance) > > test/jdk/java/util/zip/DeflaterDictionaryTests.java line 113: > >> 111: >> 112: Assertions.assertEquals(resultLength, SRC_DATA.length()); >> 113: Assertions.assertArrayEquals(Arrays.copyOf(result, >> resultLength), input); > > I think we should restore the original order here - maybe someone used testng > the junit way. Same below. Thanks for spotting these incorrect ordering placements. Addressed in https://github.com/openjdk/jdk/pull/29552/commits/879b286da9ec08e3a3211fba42d5f8757478d224. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2765518712
