Hi Frank
Frank Schönheit - Sun Microsystems Germany escribió:
Hi Ariel,
RESULT: the constructor returns an XCopyTableWizard reference, but
XExecutableDialog.execute() makes OOo crash (without crash report -- at
least here in Linux)
It does here, too :(
That'd be fixed.
In some sense, it *was* the wizard: It used the file driver in a way it
had never been used before ... :-\ An instead of throwing an exception,
the driver just crashed.
Thanks for finding this.
you're welcome
In the course of the fix, I also changed the behaviour to what you
suggested: Invalid tables are noticed at creation time. That's not
really my ideal solution, but ...
I "suggested" but you decided ...
We're talking about an UNO *wrapper*
here. The wrapped code would need some more re-factoring to be able to
properly propagate this error to the caller, so I decided to stay, for
the moment, with checking the table beforehand.
...
You made a good point: between creating the wizard, and executing it,
somebody could drop the table just passed (although I can't think of a
program doing much in between, at least from create() to execute() I
only set the XCopyTableWizard attributes, all my job I do it before
creating the object...)
By the way, a doubt: should we dispose() the dialog after execute()
returns? I "always" do it with other XExecutableDialog's (as the GUI
chap. says to always dispose() the FilePicker).
And another one: I always remove everything I add (like listeners), but:
is it really needed? or when the object gets disposed (by me or others)
all references get released?
Applied to this case: should we remove the XCopyTableListener after
execute() + then dispose()?
Bye
Ariel
--
Ariel Constenla-Haile
La Plata, Argentina
[EMAIL PROTECTED]
[EMAIL PROTECTED]
http://www.arielconstenlahaile.com.ar/ooo/
"Aus der Kriegsschule des Lebens
- Was mich nicht umbringt,
macht mich härter."
Nietzsche Götzendämmerung, Sprüche und Pfeile, 8.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
