Kicked off a functional run with your branch. Will let you know once it finishes
- Rahul On Wed, Jan 27, 2016 at 9:56 PM, Jacques Nadeau <jacq...@dremio.com> wrote: > 4196 was merged today. I have an updated patch for 4291 that is ready. > Unfortunately, it seems that something isn't working with our extended > tests so I haven't been able to run an extended regression. Unit tests > pass. Is someone else possibly able to run a regression suite against this > branch [1] so we can confirm things look good and start the release > process? > > thanks, > Jacques > > [1] https://github.com/jacques-n/drill/tree/DRILL-4291v2 > > -- > Jacques Nadeau > CTO and Co-Founder, Dremio > > On Mon, Jan 25, 2016 at 11:20 AM, Jacques Nadeau <jacq...@dremio.com> > wrote: > > > I think the main things are 4196 and 4291 should be completed. I know > Amit > > was able to reproduce 4196 locally this weekend so I think we're close on > > that. > > > > -- > > Jacques Nadeau > > CTO and Co-Founder, Dremio > > > > On Mon, Jan 25, 2016 at 10:14 AM, Zelaine Fong <zf...@maprtech.com> > wrote: > > > >> Any updates on this? What's blocking us from taking this to a vote -- > the > >> sort merge join issues? > >> > >> -- Zelaine > >> > >> On Tue, Jan 19, 2016 at 4:18 PM, Jacques Nadeau <jacq...@dremio.com> > >> wrote: > >> > >> > Bumping this thread... > >> > > >> > Here are the issues that were mentioned in this thread along with a > >> > proposed categorization: > >> > > >> > Release Blockers > >> > In-progress Amit https://issues.apache.org/jira/browse/DRILL-4190 > >> > In-progress Amit https://issues.apache.org/jira/browse/DRILL-4196 > >> > Ready to merge Jacques > https://issues.apache.org/jira/browse/DRILL-4246 > >> > In-review Jinfeng https://issues.apache.org/jira/browse/DRILL-4256 > >> > In-progress Jacques https://issues.apache.org/jira/browse/DRILL-4278 > >> > Ready to merge Laurent > https://issues.apache.org/jira/browse/DRILL-4285 > >> > Nice to Have > >> > Open Jason/Hakim https://issues.apache.org/jira/browse/DRILL-4247 > >> > In-progress Jason https://issues.apache.org/jira/browse/DRILL-4203 > >> > Open Jacques https://issues.apache.org/jira/browse/DRILL-4266 > >> > Ready to merge Jacques > https://issues.apache.org/jira/browse/DRILL-4131 > >> > > >> > What do others think? Let's try to get the blockers wrapped up in the > >> next > >> > day or two and start a release vote... > >> > > >> > > >> > > >> > -- > >> > Jacques Nadeau > >> > CTO and Co-Founder, Dremio > >> > > >> > On Mon, Jan 4, 2016 at 1:48 PM, Jason Altekruse < > >> altekruseja...@gmail.com> > >> > wrote: > >> > > >> > > Hello All, > >> > > > >> > > With the allocator changes merged and about a month since the last > >> > release > >> > > I think it would be good to start a vote soon. I would like to > >> volunteer > >> > to > >> > > be release manager. > >> > > > >> > > I know that there were some issues that were identified after the > >> > transfer > >> > > patch was merged. I think that these issues should be fixed before > we > >> > cut a > >> > > release candidate. > >> > > > >> > > From looking at the associated JIRAs it looked like there was a > >> possible > >> > > short term fix just adjusting the max_query_memory_per_node option, > >> and > >> > > some more involved work to change how we determine the correct time > to > >> > > spill during external sort. I believe it makes sense to make > external > >> > sort > >> > > work well with the newly improved memory accounting before cutting a > >> > > release, but I'm not sure how much work is left to be done there. > [1] > >> > > > >> > > Please respond with your thoughts on a release soon and any JIRAs > you > >> > would > >> > > like to include in the release. > >> > > > >> > > [1] - https://issues.apache.org/jira/browse/DRILL-4243 > >> > > > >> > > Thanks, > >> > > Jason > >> > > > >> > > >> > > > > >