It just depends on what behavior you want. Some could argue that for certain 'official feature branches' they want this behavior and for random WIP branches they don't. Given the script INFRA uses is for all the projects, if they object to letting us only get the original commits, it's just another another legitimate option one would want that more fits with the idea of they apparently think this should work. Which is why I say, "at a minimum" we should have this option.
- Mark On Wed, Feb 3, 2016 at 4:01 PM david.w.smi...@gmail.com < david.w.smi...@gmail.com> wrote: > https://issues.apache.org/jira/browse/INFRA-11198 > I don't think this has to do with some branches being more significant > than others. I think it has to do with the fact that the commit has > occurred multiple times (same hash); we just care about the first > chronologically. Any way; further discussion of our theories on how to fix > it should happen on the issue. > > On Wed, Feb 3, 2016 at 3:42 PM david.w.smi...@gmail.com < > david.w.smi...@gmail.com> wrote: > >> +1 I'll do it. >> >> On Wed, Feb 3, 2016 at 3:29 PM Mark Miller <markrmil...@gmail.com> wrote: >> >>> Yeah man, ugly noise. I think we should open a JIRA to discuss with >>> INFRA anyway. At a minimum, we should be able to specify which main >>> branches we care about. Creating noise for everyone's random work branches >>> is crazy. >>> >>> - Mark >>> >>> On Wed, Feb 3, 2016 at 3:09 PM david.w.smi...@gmail.com < >>> david.w.smi...@gmail.com> wrote: >>> >>>> Ok thanks. It's too bad it's not going to be changed. IMO, I don't >>>> these extra commit notifications are helpful beyond the original appearance >>>> of a given commit. >>>> ~ David >>>> >>>> On Tue, Feb 2, 2016 at 10:52 PM Ryan Ernst <r...@iernst.net> wrote: >>>> >>>>> By the way, I meant I attended a talk *about git at apache* >>>>> On Feb 2, 2016 19:50, "Ryan Ernst" <r...@iernst.net> wrote: >>>>> >>>>>> This is expected, as merging in the commit to a branch does create a >>>>>> new commit for that branch (or rather it is then visible in the history >>>>>> of >>>>>> that branch while before it was not). >>>>>> >>>>>> Two years ago at ApacheCon I attended a talk by David Nalley. This >>>>>> issue was brought up, and I spoke a little with him afterwards about it. >>>>>> At >>>>>> that time, infra had no plans to change anything about how the alerts >>>>>> worked. >>>>>> On Feb 2, 2016 19:43, "david.w.smi...@gmail.com" < >>>>>> david.w.smi...@gmail.com> wrote: >>>>>> >>>>>>> I noticed something different today about the bot that posts git >>>>>>> commits to applicable JIRA issues. I recently worked on SOLR-7968 -- >>>>>>> super >>>>>>> simple with 2 commits, one for master and one for branch_5x. I promptly >>>>>>> saw a comment appear after each commit. But then today, to my >>>>>>> surprise, I >>>>>>> got notified of a new comment from this bot on this issue that was not >>>>>>> triggered by an action on my part.: >>>>>>> >>>>>>> >>>>>>> https://issues.apache.org/jira/browse/SOLR-7968?focusedCommentId=15127982&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15127982 >>>>>>> >>>>>>> Notice it's for a branch master-solr-8621. Christine apparently >>>>>>> created the branch, did some work, and then brought it up to date with >>>>>>> master. That must have caused this commit. Does anyone know if the >>>>>>> ASF or >>>>>>> whoever knows about this and perhaps is working to fix it? I'm sure the >>>>>>> coding of the bot could be improved to account for this situation; there >>>>>>> seems to be enough metadata to differentiate. >>>>>>> >>>>>>> ~ David >>>>>>> -- >>>>>>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>>>>>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>>>>>> http://www.solrenterprisesearchserver.com >>>>>>> >>>>>> -- >>>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>>> http://www.solrenterprisesearchserver.com >>>> >>> -- >>> - Mark >>> about.me/markrmiller >>> >> -- >> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >> http://www.solrenterprisesearchserver.com >> > -- > Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker > LinkedIn: http://linkedin.com/in/davidwsmiley | Book: > http://www.solrenterprisesearchserver.com > -- - Mark about.me/markrmiller
