Christian, some (potentially unwelcome) advice: Learn to use rebase, learn
to fetch, never pull, and review your changes in their new context before
pushing them.
Whether you take the advice, or not, this is how I ensure that my changes
are clean and focused and coherent, every time.
Pull is a blind operation, which basically says "get whatever is out there,
even though I have no idea what it is, and try to merge my changes with
those changes, regardless, and before reviewing what those changes are".
If you fetch first you can at least look and make a conscious decision. Not
possible if you pull.
This style fits with the Apache "just commit it" mentality, but relies on
individual developer discipline to work well. The task of "gate keeper" is
effectively distributed to each person wanting to push; they gate keep
themselves, or not.
Fred.
On Sun, Jan 8, 2017 at 1:27 PM, Tibor Digana <tibor.dig...@googlemail.com>
wrote:
> You committed right after me and you have reverted two Jira issue.
> I do not want to continue until we make agreement.
> If you want to see thrown IOException, then we can use InputStream.close()
> instead of IOUtils.close().
> Please nobody commit until we know what we clarify.
> Except for PrintWriter there is again all old staff back like missed
> flush(), etc.
> Btw. PrintWriter has a method which could be called and throw exception
> from our code
>
> public boolean checkError() {
> if (out != null) {
> flush();
> }
> if (out instanceof java.io.PrintWriter) {
> PrintWriter pw = (PrintWriter) out;
> return pw.checkError();
> } else if (psOut != null) {
> return psOut.checkError();
> }
> return trouble;
> }
>
>
>
>
> On Sun, Jan 8, 2017 at 12:47 AM, Christian Schulte <schu...@apache.org>
> wrote:
>
> > Am 01/07/17 um 04:00 schrieb Tibor Digana:
> > > I have created a pull request
> > > https://github.com/apache/maven-surefire/pull/139
> > > The build passed successfully.
> > > Christian, Benedikt please have a look and I will amend the HEAD
> revision
> > > in origin/master.
> > > Thx.
> >
> > Damn it. I did not read your emails. Could be I just made that? I "git
> > pull"ed and that produced conflicts. I solved those conflicts and then
> > pushed. Your changes are preserved, of course.
> >
> > I changed usages of "PrintWriter" to a "real" writer where possible
> > (only used privately) because the PrintWriter does not throw any
> > IOException and all "checkError" calls where missing.
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>
>
> --
> Cheers
> Tibor
>
